Re: New security/py-pysha3

On 2019/09/23 15:21, clematis wrote:
> Hi Team,
>
> kurt@ pointed out that I've missed the pysha3 dependencies working on
> devel/py-merkletools.

that is kmos@

> Attached is a first submission for security/py-pysha3.
>
> From previous conversations I understood devel/ was getting busy so
> security/ sounded like the best fit.
> All regression tests (50 tests) completed OK on amd64 for *both* flavors.
> This does satisfy the devel/py-merkletools dep but I am still running
> further testing on that specific one with both flavors. I will update
> the other email thread once I am done.

: COMMENT = python SHA-3 implementation

as a proper noun Python should start with caps.

: MAINTAINER = Clem Atis <clematis@insiberia.net>

nitpicking, but you have =<space><space><space><space><tab>, please
zap the extra spaces and just use tabs there

: RUN_DEPENDS = devel/py-setuptools${MODPY_FLAVOR}
: TEST_DEPENDS = devel/py-setuptools${MODPY_FLAVOR}
:
: MODPY_PI = Yes
: MODPY_SETUPTOOLS = Yes

MODPY_SETUPTOOLS already adds to dependencies as necessary
(RUN_DEPENDS and BUILD_DEPENDS; TEST_DEPENDS isn't needed for something
which is already in BUILD_DEPENDS because you can't test until you've
built it).