Re: port libvips

Le mercredi 11 septembre 2019, 23:30:30 CEST Stuart Henderson a écrit :


> > >
> > > Please add "COMPILER = base-clang ports-gcc" since some C++ code
> > > is
> > > built.
> > >
> > > I suspect devel/glib2 should be in LIB_DEPENDS and not
> > > RUN_DEPENDS.
> > >
> > >
> > > See ./configure --help, all optional dependencies (see below) you
> > > don't want should be disabled explicitely with --without-<lib>.
> > > "CONFIGURE_ARGS = --without-foo ..."
> > > Generally speaking all the libraries you want to use should be
> > > listed
> > > in LIB_DEPENDS (then don't forget to regen WANTLIB).
> >
> > Thing is... I don't care for those. But I think the users might.
> > Will
> > they want or not to use cairo ? PNG ? JPG ? It should be for them to
> > choose. No ? (I see things this way). Or should I make flavours ? I
> > am not sure. :)
>
> OpenBSD ports typically do things one of two ways:
>
> 1 (most common), pick a sane set of dependencies and avoid the
> options. Things that will already be installed on a typical system
> of a user who would use the software.
>
> 2 (I don't think this applies to libvips), in some cases there is a
> 'modular' build where the code relying on optional dependencies are
> kept in a separate file (executable or .so module), in this case
> sometimes the port will build a wide set but split the less common
> ones off to subpackages.
>
> Sometimes a port will have multiple flavours but this is relatively
> uncommon as it's a pain to test, upgrade, and with interactions with
> other ports, especially for a library.
>
> > The port builds well like that, auto detection of libraries and
> > such,
> > and for what I can see, no problem running.
>
> The main purpose of having a port in OpenBSD is so that packages can
> be built, and those packages should not vary depending on what
> software is installed on the machine at the time. For faster arches
> we do snapshot package builds of the entire ports tree 5+ times a
> week and the set of packages installed on the system will change from
> build to build (and maybe removed at any time during the build, aka
> "junked", unless they are recorded as a dependency in the port). So
> these need to either be listed explicitly or disabled.
>
>
> SHARED_LIBS += vips 53.1 # 53.1
> SHARED_LIBS += vips-cpp 53.1 # 53.1
>
> upstream's original version number (from shared_libs.log etc) should
> be kept in the comment, but the version number actually used by the
> port should start at 0.0. see
> www.openbsd.org/faq/ports/specialtopics.html about control of shared
> library versions.

Is it better ? :)

Thanks for help and comments