On Mon, Sep 23, 2019 at 12:51:20AM +0200, clematis wrote:
> On Sat, Sep 21, 2019 at 01:23:43PM -0400, Kurt Mosiejczuk wrote:
> > There's also the python 2.7 flavor to test. There's also 9 ports that use
> > it as a TEST_DEPENDS (that number expands to 12 for RUN_DEPENDS). Did you
> > test those?
> In regards to python 2.7: 2 failed, 1097 passed
Is that the same number as the old version? If so, maybe not a big deal.
If they are new, we might want to check.
> I've doubled check the python 3 tests: 1133 passed, 8 warnings
A good sign.
> I've done some more testing with py3, they all build and install OK, various
> results regarding the tests.
They should build and install OK since you aren't changing them, just one
of their dependencies. The regression tests make a nice stand-in for knowing
how to run all these packages.
> /usr/ports/databases/py-ldap,python3
> test: failed (would need to investigate further)
Did it fail before your change? I'm guessing so since I just tried it and
it didn't work. In which case, probably not a big deal.
> /usr/ports/devel/py-asn1-modules,python3
> test: OK (93 passed)
Is 93 all of them? I don't know the number off the top of my head :)
I'm guessing yes, so good.
The problem before was you were reporting that it worked fine with a port
not even in the tree yet. That's nice and all, but if it broke all the
consumers of it in the tree, that would be bad. If something will break
most of the consumers, we'll either see how to fix the issue or wait
on updating.
I often go through and run the tests of all the consumers and *then* install
my updated port and try again. No sense beating my head against it if it
works exactly the same as before. (Although, always bonus points if you
fix them).
> > https://github.com/danieljakots/obsd-ports-tools
> Thanks!
You're welcome.
> I will also run some more tests with py2.7.
OK, let us know.
--Kurt
No comments:
Post a Comment