Friday, October 04, 2019

kile: fix missing okular wantlib, turn kinit into rundep

Prompted my rdadowski regarding another issue, I looked at editors/kile,
installed it and was immediately prompted by an error box stating
required Okular not be installed.

It's in LIB_DEPENDS but not in WANTLIB, hence not being picked up as
RUN_DEPENDS.

port-lib-depends-check does not warn about it because kile does not link
against it; libOkular is being dlopen(3)ed at runtime as can be seen
with `ktrace -t cn'.

While here, kile also does not link against kinit but still requires it
at runtime, so move it from LIB to BUILD and RUN_DEPENDS; no library
usage involved.

OK?


Index: Makefile
===================================================================
RCS file: /cvs/ports/editors/kile/Makefile,v
retrieving revision 1.37
diff -u -p -r1.37 Makefile
--- Makefile 12 Jul 2019 20:46:05 -0000 1.37
+++ Makefile 4 Oct 2019 14:33:14 -0000
@@ -5,7 +5,7 @@ COMMENT = user-friendly TeX/LaTeX editor
CATEGORIES = editors

DISTNAME = kile-2.9.92
-REVISION = 0
+REVISION = 1

HOMEPAGE = https://kile.sourceforge.io

@@ -22,6 +22,9 @@ WANTLIB += KF5WindowSystem KF5XmlGui Qt5
WANTLIB += Qt5Gui Qt5Network Qt5Script Qt5Widgets Qt5Xml c m poppler
WANTLIB += poppler-qt5

+# dlopen(3)
+WANTLIB += Okular5Core
+
MASTER_SITES = ${MASTER_SITE_SOURCEFORGE:=kile/}
EXTRACT_SUFX = .tar.bz2

@@ -30,11 +33,12 @@ MODULES = devel/kf5 \

BUILD_DEPENDS +=devel/gettext,-tools \
devel/kf5/kdoctools \
- x11/kde-applications/okular \
+ devel/kf5/kinit \
x11/kde-applications/kate

RUN_DEPENDS += devel/desktop-file-utils \
devel/kf5/kdoctools \
+ devel/kf5/kinit \
graphics/ImageMagick \
misc/shared-mime-info \
print/texlive/base \
@@ -54,7 +58,6 @@ LIB_DEPENDS += devel/kf5/kauth \
devel/kf5/khtml \
devel/kf5/ki18n \
devel/kf5/kiconthemes \
- devel/kf5/kinit \
devel/kf5/kjs \
devel/kf5/kparts \
devel/kf5/ktexteditor \

No comments:

Post a Comment