Sunday, October 27, 2019

[macppc/hppa] Unbreak graphics/opencv

Hi,

> http://build-failures.rhaalovely.net/powerpc/2019-10-11/graphics/opencv.log

OpenCV uses atomic operators, and as such requires extra LDFLAGS on
macppc and hppa.

Once added, it builds fine [0]. REVISION does not need to be bumped, it
never built on these archs.

Comments/feedback are welcome,

Charlène.


[0] https://bin.charlenew.xyz/opencv-3.4.7p0.log


Index: Makefile
===================================================================
RCS file: /cvs/ports/graphics/opencv/Makefile,v
retrieving revision 1.52
diff -u -p -u -p -r1.52 Makefile
--- Makefile 28 Sep 2019 18:19:13 -0000 1.52
+++ Makefile 27 Oct 2019 22:14:25 -0000
@@ -85,6 +85,12 @@ CONFIGURE_ENV = CFLAGS="${CFLAGS} -fPIC
CXXFLAGS="${CXXFLAGS} -fPIC"
.endif

+# Fix "undefined reference to `__atomic_store_8'" (and more)
+.if ${MACHINE_ARCH:Mpowerpc} || ${MACHINE_ARCH:Mhppa}
+WANTLIB += atomic
+CONFIGURE_ENV += LDFLAGS="${LDFLAGS} -latomic"
+.endif
+
# ATM opencv requires V4L1 compat, ask them to change it,
# then see WITH_V4L below.
CONFIGURE_ARGS = -DBUILD_DOCS=Off \

No comments:

Post a Comment