Thursday, October 31, 2019

Re: minor tcpdump.8 inconsistency

Otto Moerbeek <otto@drijf.net> wrote:

> On Thu, Oct 31, 2019 at 05:23:12PM +0000, Jason McIntyre wrote:
>
> > On Thu, Oct 31, 2019 at 02:15:34PM +0100, Tim Kuijsten wrote:
> > > minor inconsistency
> > >
> > > diff --git a/tcpdump.8 b/tcpdump.8
> > > index ce16951..8c2cf33 100644
> > > --- a/tcpdump.8
> > > +++ b/tcpdump.8
> > > @@ -1257,7 +1257,7 @@ end of this connection.
> > > .Ar window
> > > is the number of bytes of receive buffer space available
> > > at the other end of this connection.
> > > -.Ar urg
> > > +.Ar urgent
> > > indicates there is urgent data in the packet.
> > > .Ar options
> > > are TCP options enclosed in angle brackets e.g.,
> > >
> >
> > hi.
> >
> > have you established that it's the documentation that is wrong? i.e.
> > that "urgent" is printed, and not actually "urg"?
> >
> > jmc
> >
>
> It is "urg". The correct diff is this, I think.
>
> -Otto
>
> Index: tcpdump.8
> ===================================================================
> RCS file: /cvs/src/usr.sbin/tcpdump/tcpdump.8,v
> retrieving revision 1.107
> diff -u -p -r1.107 tcpdump.8
> --- tcpdump.8 25 Sep 2019 17:02:00 -0000 1.107
> +++ tcpdump.8 31 Oct 2019 17:28:59 -0000
> @@ -1219,7 +1219,7 @@ will be of much use to you.
> The general format of a TCP protocol line is:
> .Bd -ragged -offset indent
> .Ar src No > Ar dst :
> -.Ar flags src-os data-seqno ack window urgent options
> +.Ar flags src-os data-seqno ack window urg options
> .Ed
> .Pp
> .Ar src

I don't agree. Because then "window" needs to be replaced with "win"
as well, and through the entire next paragraph also, and some people
may not win understanding but lose it instead.

No comments:

Post a Comment