Saturday, October 26, 2019

Re: mpv: Use SUBST_VARS, stop editing WRKSRC in configure

On Sat, Oct 26, 2019 at 03:19:47PM +0200, Klemens Nanni wrote:
> On Sat, Oct 26, 2019 at 03:07:58PM +0200, Antoine Jacoutot wrote:
> > Why not us LIBmpv_VERSION:R and LIBmpv_VERSION:E instead?
> Can do as already done but having SHARED_LIBS only to split it up later
> again seems backwards.
>
> LMAJ and LMIN must exist anyway for SUBST_VARS so we can assign use them
> directly.

I mean this:

LMAJ= ${LIBmpv_VERSION:R}
LMIN= ${LIBmpv_VERSION:E}

SHARED_LIBS should be the reference value, not the opposite.

--
Antoine

No comments:

Post a Comment