Re: [NEW] security/py-fido2

On Sun, Oct 27, 2019 at 10:32:21AM -0500, Lucas Raab wrote:
> py-fido2 is a new dependency for the forthcoming yubikey-manager port.

> Feedback?

The python3 for the FLAVORS line should be indented with a tab, not a
space. Comments aren't supposed to start with an uppercase in general
(unless it is "semantically significant).

py-cryptography is actually a RUN_DEPENDS, not a BUILD_DEPENDS. It
is also missing a py-six as a RUN_DEPENDS. py-mock is missing as a
TEST_DEPENDS for python 2.7.

I usually use py-${DISTNAME} rather than ${MODPY_PY_PREFIX} just because
it's easier to read. The lang/python module will still change it to py3-.

The FLAVORS lines usually go before the DEPENDS.

Below is a diff with what I changed in the Makefile.

I've attached a new version of the port.

With these changes, OK kmos@

--Kurt

diff -uNr py-fido2/Makefile py-fido2-kmos/Makefile
--- py-fido2/Makefile Sun Oct 27 11:22:13 2019
+++ py-fido2-kmos/Makefile Sun Oct 27 16:13:36 2019
@@ -1,15 +1,15 @@
# $OpenBSD: Makefile.template,v 1.85 2019/09/09 19:19:05 kmos Exp $

-COMMENT = Provides library functionality for FIDO 2.0
+COMMENT = provides library functionality for FIDO 2.0

MODPY_EGG_VERSION = 0.7.3

-DISTNAME = fido2-${MODPY_EGG_VERSION}
-PKGNAME = ${MODPY_PY_PREFIX}${DISTNAME}
+DISTNAME = fido2-${MODPY_EGG_VERSION}
+PKGNAME = py-${DISTNAME}

-CATEGORIES = security sysutils
+CATEGORIES = security sysutils

-HOMEPAGE = https://github.com/Yubico/python-fido2
+HOMEPAGE = https://github.com/Yubico/python-fido2

# BSD
PERMIT_PACKAGE = Yes
@@ -18,10 +18,13 @@

MODPY_PI = Yes
MODPY_SETUPTOOLS = Yes
+MODPY_PYTEST = Yes

-BUILD_DEPENDS = security/py-cryptography${MODPY_FLAVOR}
-
-FLAVORS = python3
+FLAVORS = python3
FLAVOR ?=
+
+RUN_DEPENDS = devel/py-six${MODPY_FLAVOR} \
+ security/py-cryptography${MODPY_FLAVOR}
+TEST_DEPENDS = devel/py-mock${MODPY_FLAVOR}

.include <bsd.port.mk>