Thursday, October 31, 2019

Re: [NEW] security/py-fido2

On Sun, Oct 27, 2019 at 04:37:42PM -0400, Kurt Mosiejczuk wrote:
> With these changes, OK kmos@
Looks good, a few things:

Not sure how this library fits into sysutils as secondary category,
devel would fit after security, though.

setup.py lists
61 extras_require={':python_version < "3.4"': ["enum34"], "pcsc": ["pyscard"]},

That's still unaccounted for.

DESCR could contain more from ${WRKSRC}/README.adoc though.

Besides BSD, this port ships code under APL 2.0 and MPL 2.0 as well, see
the readme file.

Perhaps the example files are worth shipping as well?

OK kn with the py-enum34 dependency fixed, the rest I'll leave to
whoever commits (and maintains) this port - they're mere impressions
after a quick look.

No comments:

Post a Comment