Re: PostgreSQL 12.0

On Sat, Oct 12, 2019 at 04:41:40PM -0700, Jeremy Evans wrote:
> On 10/04 09:27, Jeremy Evans wrote:
> > On 10/04 06:12, Pierre-Emmanuel Andr? wrote:
> > > On Thu, Oct 03, 2019 at 11:26:13AM -0700, Jeremy Evans wrote:
> > > > On 10/03 09:01, Jeremy Evans wrote:
> > > > > PostgreSQL 12.0 was released today. Here's a diff to update to it.
> > > > > Tested briefly on amd64, no issues noted.
> > > >
> > > > You will probably need this diff for postgresql-previous to build
> > > > the package for postgresql.
> > > >
> > >
> > > Hi,
> > >
> > > Looks good to me. Almost the same diff in my tree.
> > > We must put this diff in a bulk to see what will fail.
> > > Thank you Jeremy :)
> >
> > I don't think this is ready for bulk testing yet. There is usually a
> > large amount of fallout in a PostgreSQL upgrade. At the very least, we
> > should run a partial bulk of the direct dependencies and make sure they
> > all build before requesting a full bulk. In my experience, it is many
> > hours of work fixing dependencies to get the ports tree ready.
> >
> > It may be a good time to reassess whether some dependencies are still
> > needed. For example, postgresql-v8 uses a 5+ year old version that has
> > been patched to handle changes in PostgreSQL internals. Upstream
> > switched the build system a few years ago and I could not get newer
> > versions to build correctly when handling the PostgreSQL 10->11 update.
>
> I checked postgresql-plv8 and it doesn't build with PostgreSQL 12:
>
> plv8.cc:425:46: error: no member named 'argnull' in 'FunctionCallInfoBaseData'
> args[i] = ToValue(fcinfo->arg[i], fcinfo->argnull[i], &argtypes[i]);
> ~~~~~~ ^
> plv8.cc:425:30: error: no member named 'arg' in 'FunctionCallInfoBaseData'; did you mean 'args'?
> args[i] = ToValue(fcinfo->arg[i], fcinfo->argnull[i], &argtypes[i]);
> ^~~
> args
> /usr/local/include/postgresql/server/fmgr.h:95:16: note: 'args' declared here
> NullableDatum args[FLEXIBLE_ARRAY_MEMBER];
> ^
> plv8.cc:521:45: error: no member named 'argnull' in 'FunctionCallInfoBaseData'
> args[i] = ToValue(fcinfo->arg[i], fcinfo->argnull[i], &argtypes[i]);
> ~~~~~~ ^
> plv8.cc:521:29: error: no member named 'arg' in 'FunctionCallInfoBaseData'; did you mean 'args'?
> args[i] = ToValue(fcinfo->arg[i], fcinfo->argnull[i], &argtypes[i]);
> ^~~
> args
> /usr/local/include/postgresql/server/fmgr.h:95:16: note: 'args' declared here
> NullableDatum args[FLEXIBLE_ARRAY_MEMBER];
> ^
> plv8.cc:1166:21: error: use of undeclared identifier 'HeapTupleGetOid'
> Oid langtupoid = HeapTupleGetOid(tuple);
>
>
> Unless someone steps forward to update it to a current or recent
> version, I propose we remove this port during p2k19. Any OKs for that?
>

I don't use it.. but if this software blocks upgrade it will become
very annoying.
FWIW ok pea@



> Thanks,
> Jeremy