Thursday, October 31, 2019

Re: [update] log4cplus 2.0.4

On 2019/10/31 15:17, sven falempin wrote:
> build ok 6.6

Your mail client mangles inline diffs (word-wraps, and replaces tabs
with spaces). this means they can't be applied with patch and need to be
re-edited by hand. You might have better luck with an attachment rather
than inline (generally it's preferred to send inline via an MTA which
doesn't break things, second best would be a working attachment, but
"inline and broken" is the worst option!)..

> Index: Makefile
> ===================================================================
> RCS file: /cvs/ports/devel/log4cplus/Makefile,v
> retrieving revision 1.10
> diff -u -p -r1.10 Makefile
> --- Makefile 26 Jul 2017 22:45:18 -0000 1.10
> +++ Makefile 31 Oct 2019 19:12:39 -0000
> @@ -2,7 +2,7 @@
> COMMENT= logging API for C++
> -DISTNAME = log4cplus-1.2.0
> +DISTNAME = log4cplus-2.0.4
> EXTRACT_SUFX= .tar.bz2
> REVISION = 0

The REVISION line should be removed when updating to a new version.

Update notes for 2.0 say "Implementation language is now C++11".
This means it no longer builds with base-gcc so please remove that from the
COMPILER line.

net/kea depends on this, have you checked that it at least still builds?

The SHARED_LIBS line also need bumping to 3.0 because the update isn't ABI compatible
with the old version.

No comments:

Post a Comment