Saturday, November 30, 2019

Re: gettext-tools poisoning; allow LIB_DEPENDS

On 2019-11-29, Stuart Henderson <stu@spacehopper.org> wrote:

> Currently we require BUILD_DEPENDS to avoid tripping the (very useful)
> poisoning that we have to detect ports with a missing dependency on
> gettext-tools. This used to be fine, but now gettext-tools includes
> libraries, a port may have LIB_DEPENDS instead of BUILD_DEPENDS.

Very few ports are affected by this. libgettextlib and libgettextsrc
are for internal use by the gettext-tools programs; only libgettextpo
is an external interface. Currently we have four ports that depend
on this library, and two of them need the redundant BUILD_DEPENDS.

> We could just require that those ports list a redundant BUILD_DEPENDS
> as well as the LIB_DEPENDS, but it's easy enough to handle the simple
> (i.e. not multi-packages) case.
>
> OK or is there a better idea?

The internal variable _BUILDLIB_DEPENDS is always defined, set
early, and collects all the LIB_DEPENDS* from multi-packages, so
you can just check !${_BUILDLIB_DEPENDS:Mdevel/gettext,-tools}.

--
Christian "naddy" Weisgerber naddy@mips.inka.de

No comments:

Post a Comment