On Fri, Nov 01, 2019 at 02:44:02PM -0500, Lucas Raab wrote:
> Updated to make it Python 3 only since the pcsc-lite depends is Python
> 3 only
PKGNAME should MODPY_PY_PREFIX instead of "py-".
DESCR should be a proper sentence, the current one is the same as
COMMENT really.
*Panel.py and diag.py which you install through PLIST use wxPython which
is tracked as dependency in setup.py, but you lack an RDEP for that.
Did you test the GUI functionality? Should it be installed?
I also wouldn't mind if the values in the Makefile's variable assignments
were aligned; this makes it much easier to read for me, but maybe that's
just me.
Other than that, regress passes and building the shared library does
honour DEBUG, so building with `-g3 -O0' does work, which is nice:
Ran 24 tests in 0.023s
Honestly I don't know whether we already do or actually should handle
this, but it just occured to me. I think we should always honour DEBUG.
No comments:
Post a Comment