Re: Update net/py-websocket-client to 0.56.0

On Thu, Nov 28, 2019 at 12:55:17PM +0100, clematis wrote:

> Hello,
> Any comments? OK? Re-attaching a diff -u this time. Still ran ok
> for me in the meantime.

Comments in-line

> Cheers,
> --
> clematis (0x7e96fd2400fe7b59)

> ? diff_net_py-websocket-client-0.56.0
> Index: Makefile
> ===================================================================
> RCS file: /cvs/ports/net/py-websocket-client/Makefile,v
> retrieving revision 1.8
> diff -u -r1.8 Makefile
> --- Makefile 12 Jul 2019 20:48:46 -0000 1.8
> +++ Makefile 28 Nov 2019 11:49:09 -0000
> @@ -2,27 +2,25 @@
>
> COMMENT = WebSocket client for Python
>
> -MODPY_EGG_VERSION = 0.37.0
> +MODPY_EGG_VERSION = 0.56.0
> DISTNAME = websocket_client-${MODPY_EGG_VERSION}
> -PKGNAME = py-websocket-client-${MODPY_EGG_VERSION}
> -REVISION = 2
> +PKGNAME = py-${DISTNAME}

You just changed the PKGNAME with that change. You need the old PKGNAME
line back in there.

> CATEGORIES = net
>
> -HOMEPAGE = https://github.com/liris/websocket-client
> +HOMEPAGE = https://github.com/websocket-client/websocket-client
>
> -# LGPLv2.1+
> +MAINTAINER = Clem Atis <clematis@insiberia.net>
> +
> +# BSD 3-Clause
> PERMIT_PACKAGE = Yes
>
> MODPY_PI = Yes
> -MODPY_PI_DIR = w/websocket-client
> MODPY_SETUPTOOLS = Yes
>
> MODULES = lang/python
> FLAVORS = python3
> FLAVOR ?=
> -
> -RUN_DEPENDS = devel/py-six${MODPY_FLAVOR}

According to the setup.py, the package requires py-six. Why are you
dropping it?

> post-install:
> mv ${PREFIX}/bin/wsdump.py ${PREFIX}/bin/wsdump.py${MODPY_BIN_SUFFIX}
> Index: distinfo
> ===================================================================
> RCS file: /cvs/ports/net/py-websocket-client/distinfo,v
> retrieving revision 1.3
> diff -u -r1.3 distinfo
> --- distinfo 3 Nov 2016 10:12:49 -0000 1.3
> +++ distinfo 28 Nov 2019 11:49:09 -0000
> @@ -1,2 +1,2 @@
> -SHA256 (websocket_client-0.37.0.tar.gz) = Z4skbYFrlAGK9Sl+cpFRYOL+sELgzeGpOX9QKsOlL0E=
> -SIZE (websocket_client-0.37.0.tar.gz) = 194246
> +SHA256 (websocket_client-0.56.0.tar.gz) = H9VSCHi2i4S1dIuzDlkrENCpFSnVOD909JZOcrKX/To=
> +SIZE (websocket_client-0.56.0.tar.gz) = 36951
> Index: pkg/PLIST
> ===================================================================
> RCS file: /cvs/ports/net/py-websocket-client/pkg/PLIST,v
> retrieving revision 1.2
> diff -u -r1.2 PLIST
> --- pkg/PLIST 7 Dec 2015 21:16:25 -0000 1.2
> +++ pkg/PLIST 28 Nov 2019 11:49:09 -0000
> @@ -1,4 +1,4 @@
> -@comment $OpenBSD: PLIST,v 1.2 2015/12/07 21:16:25 sthen Exp $
> +@comment $OpenBSD: PLIST,v$
> bin/wsdump.py${MODPY_BIN_SUFFIX}
> lib/python${MODPY_VERSION}/site-packages/websocket/
> lib/python${MODPY_VERSION}/site-packages/websocket/__init__.py
> @@ -6,6 +6,7 @@
> lib/python${MODPY_VERSION}/site-packages/websocket/${MODPY_PYCACHE}__init__.${MODPY_PYC_MAGIC_TAG}pyc
> lib/python${MODPY_VERSION}/site-packages/websocket/${MODPY_PYCACHE}_abnf.${MODPY_PYC_MAGIC_TAG}pyc
> lib/python${MODPY_VERSION}/site-packages/websocket/${MODPY_PYCACHE}_app.${MODPY_PYC_MAGIC_TAG}pyc
> +lib/python${MODPY_VERSION}/site-packages/websocket/${MODPY_PYCACHE}_cookiejar.${MODPY_PYC_MAGIC_TAG}pyc
> lib/python${MODPY_VERSION}/site-packages/websocket/${MODPY_PYCACHE}_core.${MODPY_PYC_MAGIC_TAG}pyc
> lib/python${MODPY_VERSION}/site-packages/websocket/${MODPY_PYCACHE}_exceptions.${MODPY_PYC_MAGIC_TAG}pyc
> lib/python${MODPY_VERSION}/site-packages/websocket/${MODPY_PYCACHE}_handshake.${MODPY_PYC_MAGIC_TAG}pyc
> @@ -17,6 +18,7 @@
> lib/python${MODPY_VERSION}/site-packages/websocket/${MODPY_PYCACHE}_utils.${MODPY_PYC_MAGIC_TAG}pyc
> lib/python${MODPY_VERSION}/site-packages/websocket/_abnf.py
> lib/python${MODPY_VERSION}/site-packages/websocket/_app.py
> +lib/python${MODPY_VERSION}/site-packages/websocket/_cookiejar.py
> lib/python${MODPY_VERSION}/site-packages/websocket/_core.py
> lib/python${MODPY_VERSION}/site-packages/websocket/_exceptions.py
> lib/python${MODPY_VERSION}/site-packages/websocket/_handshake.py
> @@ -26,15 +28,16 @@
> lib/python${MODPY_VERSION}/site-packages/websocket/_ssl_compat.py
> lib/python${MODPY_VERSION}/site-packages/websocket/_url.py
> lib/python${MODPY_VERSION}/site-packages/websocket/_utils.py
> -lib/python${MODPY_VERSION}/site-packages/websocket/cacert.pem
> lib/python${MODPY_VERSION}/site-packages/websocket/tests/
> lib/python${MODPY_VERSION}/site-packages/websocket/tests/__init__.py
> ${MODPY_COMMENT}lib/python${MODPY_VERSION}/site-packages/websocket/tests/${MODPY_PYCACHE}/
> lib/python${MODPY_VERSION}/site-packages/websocket/tests/${MODPY_PYCACHE}__init__.${MODPY_PYC_MAGIC_TAG}pyc
> +lib/python${MODPY_VERSION}/site-packages/websocket/tests/${MODPY_PYCACHE}test_cookiejar.${MODPY_PYC_MAGIC_TAG}pyc
> lib/python${MODPY_VERSION}/site-packages/websocket/tests/${MODPY_PYCACHE}test_websocket.${MODPY_PYC_MAGIC_TAG}pyc
> lib/python${MODPY_VERSION}/site-packages/websocket/tests/data/
> lib/python${MODPY_VERSION}/site-packages/websocket/tests/data/header01.txt
> lib/python${MODPY_VERSION}/site-packages/websocket/tests/data/header02.txt
> +lib/python${MODPY_VERSION}/site-packages/websocket/tests/test_cookiejar.py
> lib/python${MODPY_VERSION}/site-packages/websocket/tests/test_websocket.py
> lib/python${MODPY_VERSION}/site-packages/websocket_client-${MODPY_EGG_VERSION}-py${MODPY_VERSION}.egg-info/
> lib/python${MODPY_VERSION}/site-packages/websocket_client-${MODPY_EGG_VERSION}-py${MODPY_VERSION}.egg-info/PKG-INFO