Re: [base-gcc/all archs] Unbreak mail/exim

On Sun, 29 Dec 2019 19:15:58 +0000
Stuart Henderson wrote:

> On 2019/12/29 20:09, Charlene Wendling wrote:
> > Hi,
> >
> > > http://build-failures.rhaalovely.net/sparc64/2019-12-25/mail/exim,ldap,-eximon.log
> > (no powerpc/mips64 log yet)
> >
> > It appears that upstream decided to move to C99 in that version [0].
> >
> > As such, `-std=gnu99' needs to be used on base-gcc archs. This fixes
> > the build on macppc [1] and still builds fine on amd64.
> >
> > Comments/feedback are welcome,
>
> I'll leave the decision up to MAINTAINER but I think I'd prefer to
> only set this on arches which need it.
>

Here is an alternate diff.

I've dropped REVISION bumps since that exim version never built on
base-gcc archs.

Index: Makefile
===================================================================
RCS file: /cvs/ports/mail/exim/Makefile,v
retrieving revision 1.128
diff -u -p -u -p -r1.128 Makefile
--- Makefile 16 Dec 2019 14:40:39 -0000 1.128
+++ Makefile 29 Dec 2019 19:28:05 -0000
@@ -86,6 +86,11 @@ LIB_DEPENDS-main += security/cyrus-sasl2
WANTLIB-main += sasl2
.endif

+# Needed to build with base-gcc
+.if !${PROPERTIES:Mclang}
+CFLAGS += -std=gnu99
+.endif
+
EXIM_EXTRA_LIBS += -L${LOCALBASE}/lib -liconv

EXIM_MAKECAT += "BIN_DIRECTORY=${PREFIX}/bin\n"