Re: patch: make dpb and ports more uniform

On Wed, Dec 04, 2019 at 04:29:19PM +0000, Stuart Henderson wrote:
> On 2019/12/04 14:29, Marc Espie wrote:
> > On Wed, Dec 04, 2019 at 12:55:33PM +0000, Stuart Henderson wrote:
> > > On 2019/12/04 12:43, Christian Weisgerber wrote:
> > > > On 2019-12-03, Antoine Jacoutot <ajacoutot@bsdfrog.org> wrote:
> > > >
> > > > >> # XXX libreoffice has its own way to build things in parallel
> > > > >> USES_PARALLEL_MAKE = No
> > > > >>
> > > > >> ?
> > > > >
> > > > > +1
> > > >
> > > > Like USES_GMAKE, USES_GROFF, USES_LIBTOOL, ...?
> > >
> > > hmm, fair point.
> > >
> > > Perhaps we could do something like this instead, and set PARALLEL_MAKE_FLAGS
> > > to nothing in libreoffice etc.
> > >
> > > (I'm unsure about ALL_FAKE_FLAGS, I don't think anything currently
> > > uses PARALLEL_INSTALL=No, but there have been cases before where
> > > parallel-build is OK but parallel-install isn't).
> >
> > None of them uses DPB_PROPERTIES=parallel
> >
> > dpb thinks there are n jobs per machine during fake, only package becomes
> > single job.
> >
> > I'm okay with your version.
> >
> > Let's get this in before it turns into the bike-shed from hell
> >
>
> So here's a diff with the various parts for ports, including removing
> the pseudo flavour for libreoffice, I've quickly edited README.internals
> but not manpages.
>
> I'm not sure about the change in default behaviour though, it means
> that unless you set PARALLEL_MAKE_JOBS explicitly, it will now build
> with hw.ncpuonline by default for all DPB_PROPERTIES=parallel ports.
> This won't get well on smaller-memory machines.

Blah. You could make it half that on, say 32 bit arches.
This can happen later if neede be.