On 2019/12/30 20:30, Edd Barrett wrote:
> On Mon, Dec 30, 2019 at 01:37:28PM +0000, Stuart Henderson wrote:
> > On 2019/12/30 13:24, Edd Barrett wrote:
> > > * Make removal of .a and .la automatic (assuming we want to do as the
> > > pre-existing comment said, and not install them).
> >
> > Better to not build them in the first place, does LIBTOOL_FLAGS = --disable-static
> > work?
>
> I'm afraid that doesn't work:
Oops sorry, --tag=disable-static
> > September 17, 2019
> > - Release 2.42.2 - ( Never fully released due to CI/CD hardware issues )
> > - Fix deployment issues. Builds can now be found under:
> > http://www2.graphviz.org/Packages/
> >
> > https://www2.graphviz.org/Packages/stable/portable_source/graphviz-2.42.3.tar.gz
>
> Weird that 2.42.3 is not tagged in git:
> https://gitlab.com/graphviz/graphviz/issues/1646#note_265898765
yep. The directories in gitlab don't match the 2.42.3 tarball either,
and gitlab has a set of cmake build infrastructure alongside autoconf,
2.42.3 tarball only has autoconf.
> Also raised a bug for the missing test files, as this is still the case
> for 2.42.3:
> https://gitlab.com/graphviz/graphviz/issues/1647
>
> Anyway, the following diff is for 2.42.3 as found in the source tarball
> Stuart linked.
I think that's probably the better one to use for now, it looks like it's
the file that's most intended for people to use and it's used by various
other OS (alpine, arch/manjaro, freebsd, gentoo).
> I'll do a partial bulk soon to test consumers.
Let's see how that goes but generally this is looking good.
> diff -N patches/patch-tests_regression_tests_Makefile_in
> --- /dev/null 1 Jan 1970 00:00:00 -0000
> +++ patches/patch-tests_regression_tests_Makefile_in 30 Dec 2019 20:22:46 -0000
> @@ -0,0 +1,18 @@
> +$OpenBSD$
> +
> +A couple of tests have missing files in the source distribution.
> +
> +https://gitlab.com/graphviz/graphviz/issues/1647
> +
> +Index: tests/regression_tests/Makefile.in
> +--- tests/regression_tests/Makefile.in.orig
> ++++ tests/regression_tests/Makefile.in
> +@@ -513,7 +513,7 @@ target_alias = @target_alias@
> + top_build_prefix = @top_build_prefix@
> + top_builddir = @top_builddir@
> + top_srcdir = @top_srcdir@
> +-SUBDIRS = shapes vuln
> ++SUBDIRS =
That seems a sane way to handle it.
No comments:
Post a Comment