On Sun, Dec 29, 2019 at 07:57:46PM -0800, Nam Nguyen wrote:
> Python 2 is used because python 3 is currently problematic, as
> reported by FreeBSD. https://github.com/arvidn/libtorrent/issues/4204
Perhaps some other issue, I don't quite recall, but broken Python 3
support is what halted my efforts earlier this year trying to update it.
For now, I wasted enough time on this and have no plans to give it
another before upstream fully supports Python 3, sorry.
> Testing
> =======
> Feedback and tests are welcome because this is a major update. I tested
> it by downloading and seeding a linux ISO. I did not get to test a thin
> client / server setup for example.
qbittorrent is another consumer, did you test this as well?
Port-wise looks good so far, but as per above I haven't tested any of
it; a few comments/nits inline.
> -SHARED_LIBS += torrent-rasterbar 1.0 # 9.0.0
> +SHARED_LIBS += torrent-rasterbar 2.0 # 9.0.0
I think upstream's version got bumped to 10.0.0 or so, did you check?
> -MODULES = lang/python
> +MODULES = devel/cmake \
> + lang/python
> +
> +MODPY_SETUPTOOLS = Yes
Perhaps leave a comment about Python 3 being broken?
> --- /dev/null 1 Jan 1970 00:00:00 -0000
> +++ patches/patch-include_libtorrent_buffer_hpp 30 Dec 2019 02:32:22 -0000
> @@ -0,0 +1,23 @@
> +$OpenBSD$
Please add a brief comment such that it appears in `make patch' output.
> Index: patches/patch-include_libtorrent_config_hpp
> ===================================================================
> RCS file: /cvs/ports/net/libtorrent-rasterbar/patches/patch-include_libtorrent_config_hpp,v
> retrieving revision 1.2
> diff -u -p -r1.2 patch-include_libtorrent_config_hpp
> --- patches/patch-include_libtorrent_config_hpp 30 Apr 2019 16:45:26 -0000 1.2
> +++ patches/patch-include_libtorrent_config_hpp 30 Dec 2019 02:32:22 -0000
> @@ -2,7 +2,7 @@ $OpenBSD: patch-include_libtorrent_confi
> Index: include/libtorrent/config.hpp
> --- include/libtorrent/config.hpp.orig
> +++ include/libtorrent/config.hpp
> -@@ -562,6 +562,10 @@ int snprintf(char* buf, int len, char const* fmt, ...)
> +@@ -411,6 +411,10 @@ POSSIBILITY OF SUCH DAMAGE.
> #define TORRENT_USE_UNC_PATHS 0
>
No comments:
Post a Comment