Namaste misc,
Overview:
In update_known_hosts function in file src/usr.bin/ssh/clientloop.c [1],
the message strings used in debug and error functions may need to be
changed.
Bug:
In src/usr.bin/ssh/clientloop.c,
...
static void
update_known_hosts(struct hostkeys_update_ctx *ctx)
{
...
if (errno == ENOENT) {
debug("%s: known hosts file %s does not exist",
__func__, strerror(errno));
} else {
error("%s: known hosts file %s inaccessible",
__func__, strerror(errno));
}
...
}
...
the message strings for debug and error functions do not seem to be
correct.
Do we want to:
1) print the name of the file which does not exist/is inaccessible,
2) print the string representation of the errno,
3) both of the above.
This code was recently added in the revision 1.333 [2].
Dhanyavaad,
ab
[1] - https://cvsweb.openbsd.org/cgi-bin/cvsweb/src/usr.bin/ssh/clientloop.c?rev=1.338&content-type=text/x-cvsweb-markup
[2] - https://cvsweb.openbsd.org/cgi-bin/cvsweb/src/usr.bin/ssh/clientloop.c.diff?r1=1.332&r2=1.333&f=h
---------|---------|---------|---------|---------|---------|---------|--
No comments:
Post a Comment