Saturday, February 01, 2020

[ld.bfd] Unbreak audio/mscore, drop google analytics

Hi,

(If you wonder: telemetry is not activated by default at runtime)

I've found that the latest mscore was broken during the last sparc64
bulk while trying to link some google analytics third party library:

> thirdparty/google_analytics/libgoogle_analytics.a(ganalytics.cpp.o): In function `GAnalyt
> ics::Private::getUserAgent()':
> ganalytics.cpp:(.text+0xb38): undefined reference to `GAnalytics::Private::getSystemInfo(
> )'

To fix that, i removed telemetry from the build.

Note that when using Musescore and activating telemetry in preferences,
it causes a permanent freeze on my amd64 and powerpc machines, with or
without that diff.

It builds fine on powerpc [0], sparc64 (thanks Kurt!) and amd64.


Comments/feedback are welcome,

Charlène.


[0] https://bin.charlenew.xyz/mscore.log


Index: Makefile
===================================================================
RCS file: /cvs/ports/audio/mscore/Makefile,v
retrieving revision 1.51
diff -u -p -u -p -r1.51 Makefile
--- Makefile 25 Jan 2020 18:31:10 -0000 1.51
+++ Makefile 1 Feb 2020 12:52:30 -0000
@@ -3,6 +3,7 @@
BROKEN-hppa = ICE on moc_qtsingleapplication.cxx

V = 3.4.1
+REVISION = 0
COMMENT = WYSIWYG music notation software (MuseScore)
DISTNAME = MuseScore-${V}
PKGNAME = musescore-${V}
@@ -50,7 +51,8 @@ CONFIGURE_ARGS =-DCMAKE_INSTALL_PREFIX="
-DBUILD_PCH=OFF \
-DBUILD_WEBENGINE=OFF \
-DUSE_SYSTEM_FREETYPE=ON \
- -DBUILD_CRASH_REPORTER=OFF
+ -DBUILD_CRASH_REPORTER=OFF \
+ -DBUILD_TELEMETRY_MODULE=OFF

NO_TEST = Yes
MAJ_MIN = ${V:C/^([0-9]+\.[0-9]+).*/\1/}

No comments:

Post a Comment