On 2020/02/02 04:05, Xiyue Deng wrote:
> Seems no one cares about this port. Is it OK that I apply for maintainer?
Certainly. It is a bit easier to take patches from someone that feels
responsible enough for a port to be listed as maintainer :)
> >>>> >>> * Many of the patches just replace "#!/usr/bin/env bash" to
> >>>> >>> "#!/bin/sh". Now most of scripts are changed to use "#!/usr/bin/env
> >>>> >>> sh" which should now be the same thing. Should we just drop those
> >>>> >>> patches?
It's not quite the same thing because env searches your path.
Explicit /bin/sh seems a much better idea to me so I'm happier to keep those.
> >>>> >>> * One of the patches changes the system /etc/msmtprc to provide an
> >>>> >>> "account default" that listens on localhost:25, which will then use
> >>>> >>> smtpd as server by default. I think the intention is to provide a
> >>>> >>> working configure that works out of the box. However this may not do
> >>>> >>> what you want because if one try to configure an account in a user
> >>>> >>> configuration and somehow it contains errors (e.g. not properly
> >>>> >>> provide a "from" address), msmtp will just send the mail through smtpd
> >>>> >>> and returns OK which will result in the mail stuck in the system mail
> >>>> >>> queue forever. So my suggestion is to leave this file untouched so
> >>>> >>> that the system /etc/msmtprc will just provide a fake "account
> >>>> >>> default" and any mail not handled with a user provided account will
> >>>> >>> fail immediately.
i.e. remove patch-doc_msmtprc-system_example? I'd be ok with that.
No comments:
Post a Comment