Re: [update patch] remind 3.1.16 -> 3.3.0

On Wed, Feb 26, 2020 at 11:35:03AM +0100, Martin Ziemer wrote:
> On Wed, Feb 26, 2020 at 11:15:37AM +0100, Bjorn Ketelaars wrote:
> > On Mon 24/02/2020 14:15, Martin Ziemer wrote:
> > > This patch updates remind from 3.1.16 to 3.3.0.
> > >
> > > Since i saw there is no maintainer, i also added myself as maintainer.
> > >
> > > Tested the new version on three amd64 systems.
> >
> > I'm seeing the issue below. Does tkremind work for you?
> >
> > $ tkremind
> > Error in startup script: couldn't recognize image data
> > while executing
> > "image create photo leftarrow -data {
> > iVBORw0KGgoAAAANSUhEUgAAAAwAAAAMCAYAAABWdVznAAAC3XpUWHRSYXcgcHJvZmlsZSB0eXBl
> > IGV4aWYAAHja7ZdRkuMoDIbfOcUeAUkIieNg..."
> > (file "/usr/local/bin/tkremind" line 54)
> Get the same error. (My usage is daily cli and weekly export to ps for
> printing)
> I should have tested this too!
>
> I will look into it and try to get a solution.
>
> Just one day after i mailed this patch, a beta for 3.3.1 was released.
>
> I think, i will mail a new patch as 3.3.1 is released. (If i find
> a solution to the tk problem)
Today the second beta started. (I guessed the next version would be out
on friday)
I think, as the next release could be later, we should update before
3.3.1.

To solve the problem with tkremind we need to use tk 8.6 since before
there was no support for png images. (Fixed in the patch below)

Tested the patch in cli on three amd64 systems and gui on two amd64
systems.

Index: Makefile
===================================================================
RCS file: /cvs/ports/misc/remind/Makefile,v
retrieving revision 1.38
diff -u -p -r1.38 Makefile
--- Makefile 12 Jul 2019 21:02:23 -0000 1.38
+++ Makefile 26 Feb 2020 10:46:24 -0000
@@ -2,20 +2,23 @@

COMMENT= scripting language for reminders, with a Tk front end

-DISTNAME= remind-03.01.16
-PKGNAME= remind-3.1.16
+DISTNAME= remind-03.03.00
+PKGNAME= remind-3.3.0
CATEGORIES= misc

MASTER_SITES= https://dianne.skoll.ca/projects/remind/download/

HOMEPAGE= https://dianne.skoll.ca/projects/remind/

+MAINTAINER = Martin Ziemer <horrad@horrad.de>
+
# GPLv2
PERMIT_PACKAGE= Yes

WANTLIB= c m

MODULES= x11/tk
+MODTK_VERSION = 8.6
RUN_DEPENDS= ${MODTK_RUN_DEPENDS} \
devel/tcllib

Index: distinfo
===================================================================
RCS file: /cvs/ports/misc/remind/distinfo,v
retrieving revision 1.11
diff -u -p -r1.11 distinfo
--- distinfo 6 Mar 2019 18:24:43 -0000 1.11
+++ distinfo 26 Feb 2020 10:46:24 -0000
@@ -1,2 +1,2 @@
-SHA256 (remind-03.01.16.tar.gz) = 7reb1AGdI6Az/j6GxnLZYDmdtqJ8dH5bRmrVWDHfypM=
-SIZE (remind-03.01.16.tar.gz) = 354521
+SHA256 (remind-03.03.00.tar.gz) = lolbmBrlnDuhNsWa1UvMqk+5WRl/Nxr/TrFuyoGztho=
+SIZE (remind-03.03.00.tar.gz) = 390762