On Thu, Mar 26, 2020 at 03:09:32PM -0400, johan+openbsd-ports@huldtgren.com wrote:
> > Is there a reason you are downloading from a github commit instead of
> > using PYPI?
> I did not find it last time I checked, but that is of course much
> better.
> > Also, since this is querying a website, wouldn't net or www be a better
> > category for it?
> Yeah I wasn't sure what category to use, I thought since it's an API
> that devel would be better, I'm fine seting it to www though.
> > Also, as tb@ said, adding NO_TEST=Yes along with a comment about the lack
> > of upstream tests would be good.
> > After those corrections, I think this could go in.
> Updated tarball attached with all the changes discussed in this thread.
Alright. It has been imported. Thanks!
--Kurt
No comments:
Post a Comment