On Sat, Feb 01, 2020 at 03:29:25AM -0500, Raymond E. Pasco wrote:
> - I used a modified distfile provided by abieber with a vendor directory,
> which is necessary due to the large number of go package dependencies.
>
> - The custom version of go-libvterm used by aerc upstream includes an
> (unmodified) bundled copy of libvterm itself, which causes issues with
> the build. I instead link against devel/libvterm.
>
> - One filter script shipped with aerc (to display HTML email) depends on
> socksify (provided by security/dante) and www/w3m. I did not include these
> as RUN_DEPENDS because this is an optional script disabled by default,
> but I'm not sure whether this approach is correct.
>
> - cgo in go 1.13 (but not go 1.14) considers ~ an invalid path character,
> but the top-level package name here (and therefore WRKSRC) contains an ~.
> I remedied this by moving the vendor directory contents up to the level
> of the MODGO_WORKSPACE. This workaround shouldn't be necessary when go
> 1.14 is released.
>
> - aerc can be built with notmuch support, but notmuch isn't in ports (yet?),
> so I didn't bother with this.
Thank you for porting this! I'm trying it and so far it seems to
work.
There's only one thing that I would like to report, as I think it's
an error. In the default config, in the filters section, there are
some paths that I don't expect:
subject,~^\[PATCH=awk -f /usr/ports/pobj/aerc-0.3.0/fake-amd64/usr/local/share/aerc/filters/hldiff
#text/html=/usr/ports/pobj/aerc-0.3.0/fake-amd64/usr/local/share/aerc/filters/html
text/*=awk -f /usr/ports/pobj/aerc-0.3.0/fake-amd64/usr/local/share/aerc/filters/plaintext
In the port makefile there is a rule to generate aerc.conf that use
sed to replace @SHAREDDIR@ to $SHAREDDIR. I tried to add
SHAREDDIR=/usr/local/share/aerc to MAKE_FLAGS but it didn't work.
(this on a updated -current on amd64)
--
/Omar Polo
No comments:
Post a Comment