Re: py-msgpack 1.0.0 upgrade broke salt

...but there might be other problems

https://github.com/saltstack/salt/issues/56007

--
Sent from a phone, apologies for poor formatting.

On 10 March 2020 20:16:39 Stuart Henderson <stu@spacehopper.org> wrote:

> Looks like this was fixed in salt 2019.2.1.
>
>
> --
> Sent from a phone, apologies for poor formatting.
>
> On 10 March 2020 18:50:07 Florian Obser <florian@openbsd.org> wrote:
>
>> The release notes have
>>
>> * Remove encoding option from the Packer and Unpacker.
>>
>> ( https://github.com/msgpack/msgpack-python/blob/v1.0.0/ChangeLog.rst )
>>
>> $ doas salt-minion
>>
>> Process Process-1:
>> Traceback (most recent call last):
>> File "/usr/local/lib/python2.7/multiprocessing/process.py", line 267, in
>> _bootstrap
>> self.run()
>> File "/usr/local/lib/python2.7/multiprocessing/process.py", line 114, in run
>> self._target(*self._args, **self._kwargs)
>> File "/usr/local/lib/python2.7/site-packages/salt/scripts.py", line 146, in
>> minion_process
>> minion.start()
>> File "/usr/local/lib/python2.7/site-packages/salt/cli/daemons.py", line
>> 348, in start
>> self.minion.tune_in()
>> File "/usr/local/lib/python2.7/site-packages/salt/minion.py", line 1026, in
>> tune_in
>> self._bind()
>> File "/usr/local/lib/python2.7/site-packages/salt/minion.py", line 940, in
>> _bind
>> self.event = salt.utils.event.get_event('minion', opts=self.opts,
>> io_loop=self.io_loop)
>> File "/usr/local/lib/python2.7/site-packages/salt/utils/event.py", line
>> 143, in get_event
>> raise_errors=raise_errors)
>> File "/usr/local/lib/python2.7/site-packages/salt/utils/event.py", line
>> 271, in __init__
>> self.connect_pub()
>> File "/usr/local/lib/python2.7/site-packages/salt/utils/event.py", line
>> 383, in connect_pub
>> io_loop=self.io_loop
>> File "/usr/local/lib/python2.7/site-packages/salt/transport/ipc.py", line
>> 257, in __new__
>> client.__singleton_init__(io_loop=io_loop, socket_path=socket_path)
>> File "/usr/local/lib/python2.7/site-packages/salt/transport/ipc.py", line
>> 620, in __singleton_init__
>> socket_path, io_loop=io_loop)
>> File "/usr/local/lib/python2.7/site-packages/salt/transport/ipc.py", line
>> 280, in __singleton_init__
>> self.unpacker = msgpack.Unpacker(encoding=encoding)
>> TypeError: __init__() got an unexpected keyword argument 'encoding'
>>
>> Thanks,
>> Florian
>>
>> --
>> I'm not entirely sure you are real.