Sunday, April 26, 2020

[macppc] Unbreak net/fastnetmon, improve atomics comment

fastnetmon is broken in the current macppc bulk:

> Missing library for atomic>=0.0

Using ports-gcc's libatomic is not needed since macppc moved to clang.
I've also reworded the related comment because the original i wrote is
not so great, the new one seems better to me.

The below diff fixes the build on macppc [0].

Comments/feedback are welcome,

Charlène.


[0] https://bin.charlenew.xyz/macppc/paths/net/fastnetmon.log


Index: Makefile
===================================================================
RCS file: /cvs/ports/net/fastnetmon/Makefile,v
retrieving revision 1.7
diff -u -p -u -p -r1.7 Makefile
--- Makefile 9 Oct 2019 23:12:39 -0000 1.7
+++ Makefile 26 Apr 2020 14:01:44 -0000
@@ -37,10 +37,11 @@ CONFIGURE_ARGS += -DENABLE_LUA_SUPPORT=O
-DJSONC_INCLUDES_FOLDER="${LOCALBASE}/include/json-c" \
-DHIREDIS_INCLUDES_FOLDER="${LOCALBASE}/include/hiredis"

-# Use __atomic* function instead of __sync* ones, allowing to build on
-# the following archs.
+# Use __atomic* primitives, allowing to build on archs where there are no
+# 64-bit __sync* ones (macppc, hppa). Such archs, when using gcc, need
+# ports-gcc's libatomic on top of that.
CONFIGURE_ARGS += -DUSE_NEW_ATOMIC_BUILTINS=On
-.if ${MACHINE_ARCH} == "powerpc" || ${MACHINE_ARCH} == "hppa"
+.if ${MACHINE_ARCH} == "hppa"
WANTLIB += atomic
.endif

No comments:

Post a Comment