On Thu, Apr 30, 2020 at 12:34:47PM +0200, Klemens Nanni wrote:
> devhelp ships a single Python script which is a gedit plugin, nothing
> else in devhelp I could see requires Python at runtime.
>
> In fact, the entire lang/python module usage seems unneeded. Both
> Python 3 (through meson) and Python 2 (through another BDEP in the chain)
> are pulled in during the build anyway.
>
> gedit itself has a direct Python 3 as RDEP, so in case someone usese the
> plugin the dependency is always satisfied at runtime as well. I have
> briefly tested the gedit plugin and it spawns devhelp on pressing F2 as
> expected (In fact, gedit also an indirect Python 2 RDEP as well).
>
> devhelp not having a Python RDEP lets me install the "xfce" meta package
> without pulling in Python 2.
>
> Feedback? OK?
OK, thanks.
>
>
> Index: Makefile
> ===================================================================
> RCS file: /cvs/ports/x11/gnome/devhelp/Makefile,v
> retrieving revision 1.122
> diff -u -p -r1.122 Makefile
> --- Makefile 1 Nov 2019 19:39:56 -0000 1.122
> +++ Makefile 30 Apr 2020 10:31:21 -0000
> @@ -7,6 +7,7 @@ COMMENT= API documentation browser for
>
> GNOME_PROJECT= devhelp
> GNOME_VERSION= 3.34.0
> +REVISION= 0
>
> SHARED_LIBS += devhelp-3 1.0 # 4.0
>
> @@ -20,7 +21,6 @@ WANTLIB += pango-1.0 webkit2gtk-4.0
>
> MODULES= devel/dconf \
> devel/meson \
> - lang/python \
> x11/gnome
>
> MODGNOME_LDFLAGS= -L${X11BASE}/lib
--
Antoine
No comments:
Post a Comment