Re: [macppc] Unbreak net/fastnetmon, improve atomics comment

On Sun, 26 Apr 2020 16:48:29 +0200
Jeremie Courreges-Anglas wrote:

> On Sun, Apr 26 2020, Charlene Wendling <julianaito@posteo.jp> wrote:
> > fastnetmon is broken in the current macppc bulk:
> >
> >> Missing library for atomic>=0.0
> >
> > Using ports-gcc's libatomic is not needed since macppc moved to
> > clang. I've also reworded the related comment because the original
> > i wrote is not so great, the new one seems better to me.
>
> Better but I don't think it's useful to mention macppc/powerpc in the
> comment, since this arch has moved to clang.

You're right, it's quite redundant, i've changed the comment :)

> > The below diff fixes the build on macppc [0].
> >
> > Comments/feedback are welcome,
>
> ok jca@ for the fix, please adapt the comment as you and Jasper
> prefer.
>
> > Charlène.
> >
> >
> > [0] https://bin.charlenew.xyz/macppc/paths/net/fastnetmon.log
> >
> --
> jca | PGP : 0x1524E7EE / 5135 92C1 AD36 5293 2BDF DDCC 0DFA 74AE
> 1524 E7EE
>


Index: Makefile
===================================================================
RCS file: /cvs/ports/net/fastnetmon/Makefile,v
retrieving revision 1.7
diff -u -p -u -p -r1.7 Makefile
--- Makefile 9 Oct 2019 23:12:39 -0000 1.7
+++ Makefile 26 Apr 2020 14:54:35 -0000
@@ -37,10 +37,11 @@ CONFIGURE_ARGS += -DENABLE_LUA_SUPPORT=O
-DJSONC_INCLUDES_FOLDER="${LOCALBASE}/include/json-c" \
-DHIREDIS_INCLUDES_FOLDER="${LOCALBASE}/include/hiredis"

-# Use __atomic* function instead of __sync* ones, allowing to build on
-# the following archs.
+# Use __atomic* primitives, allowing to build on archs where there are no
+# 64-bit __sync* ones. Such archs, when using gcc, need ports-gcc's
+# libatomic on top of that.
CONFIGURE_ARGS += -DUSE_NEW_ATOMIC_BUILTINS=On
-.if ${MACHINE_ARCH} == "powerpc" || ${MACHINE_ARCH} == "hppa"
+.if ${MACHINE_ARCH} == "hppa"
WANTLIB += atomic
.endif