Bcc:
Subject: Re: sparc64 bulk build report
Reply-To:
In-Reply-To: <1bebe74f6a8d32f2@sparc64-0.ports.openbsd.org>

On Wed, May 20, 2020 at 05:27:42PM -0600, kmos@openbsd.org wrote:
> Bulk build on sparc64-0.ports.openbsd.org

> Started : Sun May 17 19:51:14 MDT 2020
> Finished: Wed May 20 17:27:14 MDT 2020
> Duration: 2 Days 21 hours 36 minutes

> http://build-failures.rhaalovely.net/sparc64/2020-05-17/devel/glade.log

glade-settings.c: In function 'glade_settings_load':
glade-settings.c:239: error: 'for' loop initial declaration used outside C99 mode
gmake[3]: *** [Makefile:686: glade-glade-settings.o] Error 1

This diff adds -std=gnu99 to CFLAGS to fix compilation on sparc64 (and
other base-gcc arches).

I tested this in the following build. It fixes the build for sparc64.

ok?

(cc maintainers)

--Kurt

Index: Makefile
===================================================================
RCS file: /cvs/ports/devel/glade/Makefile,v
retrieving revision 1.88
diff -u -p -r1.88 Makefile
--- Makefile 14 May 2020 15:13:34 -0000 1.88
+++ Makefile 21 May 2020 05:28:21 -0000
@@ -45,6 +45,8 @@ MODGNOME_TOOLS += gobject-introspection
CONFIGURE_STYLE= gnu
CONFIGURE_ARGS += --disable-webkit2gtk

+CFLAGS += -std=gnu99
+
DEBUG_PACKAGES = ${BUILD_PACKAGES}

post-install: