On Fri, May 01 2020, Stuart Henderson <stu@spacehopper.org> wrote:
> On 2020/05/01 04:30, Nam Nguyen wrote:
>> Stuart Henderson writes:
>>
>> > On 2020/04/29 15:13, Jacqueline Jolicoeur wrote:
>> >> Hi,
>> >>
>> >> I have noticed gimp-2.10.18p1 crashes everytime I try to open a file. Removing all my GIMP cache and config files has not resolved it.
>> >>
>> >> I am aware this was posted earlier. I wanted to report that this bug still exists as of today with the recent snapshots.
>> >
>> > We don't have any ideas yet. I haven't been able to reproduce it recently,
>> > the crash is in gtk+2 in possibly something theme-related so maybe try a different
>> > theme or try a different window manager or desktop environment and see if that
>> > makes it go away?
>> >
>> > The upstream bug is currently at https://gitlab.gnome.org/GNOME/gdk-pixbuf/-/issues/148
>>
>> Here is a diff for x11/gtk+2 to fix GIMP crashing. Feedback and tests
>> are welcome.
>
> awesome, thanks!
Lovely indeed. This is a fix for a bug introduced 18 years ago.
> Your diff makes sense to me but I would like to have input from someone
> upstream who knows the area. Could you post this to the bug on GNOME gitlab
> please? Or if you don't have / don't want to make an account do you mind if
> I post it?
>
> (The bug will need moving from gdk-pixbuf to gtk, hopefully someone from
> upstream on the ticket can do that).
The ticket has been moved to
https://gitlab.gnome.org/GNOME/gtk/-/issues/2684
so the comment in the patch ought to be updated.
As mentioned by Jacqueline Jolicoeur, the crash happens very often when
running gimp with MALLOC_OPTIONS=S. With this fix in place I could not
reproduce a crash with repeated C-o cycles.
Rationale and code changes LGTM. ok jca@
--
jca | PGP : 0x1524E7EE / 5135 92C1 AD36 5293 2BDF DDCC 0DFA 74AE 1524 E7EE
No comments:
Post a Comment