Re: games/ioquake3 cvs current diffs adding ppc support

> Sent: Sunday, May 31, 2020 at 10:43 AM
> From: "Charlene Wendling" <julianaito@posteo.jp>
> To: "Kirill Bychkov" <kirby@linklevel.net>
> Cc: "Alex Free" <alexjf@mail.com>, "Landry Breuil" <landry@openbsd.org>, ports@openbsd.org, abieber@openbsd.org
> Subject: Re: games/ioquake3 cvs current diffs adding ppc support
>
> Huh, looks my mail never made it to ports@ :D
>
> On Sun, 31 May 2020 09:43:46 +0300
> Kirill Bychkov wrote:
>
> > On Sun, May 31, 2020 02:28, Alex Free wrote:
> > >> Sent: Saturday, May 30, 2020 at 9:45 PM
> > >> From: "Charlene Wendling" <julianaito@posteo.jp>
> > >> To: "Landry Breuil" <landry@openbsd.org>
> > >> Cc: "Alex Free" <alexjf@mail.com>, ports@openbsd.org,
> > >> abieber@openbsd.org Subject: Re: games/ioquake3 cvs current diffs
> > >> adding ppc support
> > >>
> > >> Hi,
> > >>
> > >> On Sat, 30 May 2020 09:36:25 +0200
> > >> Landry Breuil wrote:
> > >>
> > >> > On Sat, May 30, 2020 at 09:09:13AM +0200, Alex Free wrote:
> > >> > > Successfully built and tested against current.
> > >> > >
> > >> > > Let me know if I can do anything else to make this happen.
> > >> > >
> > >> > > A new file named patch-code_qcommon_q_platform_h contains the
> > >> > > following immediately below.
> > >> >
> > >> > note that you can do a cvs add of that new file, and cvs diff
> > >> > will show it.
> > >> >
> > >> > > Below are the CVS diffs.
> > >> >
> > >> > usually, when sending a diff for a port, you to the cvs diff
> > >> > from the port directory, otherwise the person applying it will
> > >> > have to cd to /usr or use patch -p2 in that case.
> > >> >
> > >> > those are not strong remarks, your diff itself is fine, it's just
> > >> > 'best practice to get used to' if you plan to send more diffs
> > >> > (which are always welcome!)
> > >>
> > >> ^ Agreed :)
> > >>
> > >> It builds fine on macppc indeed, there are font glitches, but i
> > >> don't have much time to fiddle with q3config.cfg since i can't
> > >> read options. It requires to disable HDR at least to have proper
> > >> weapons/font textures with my Radeon 9700.
> >
> > Hi,
> > I see weapons, main menu (when option is highlighted) and console on
> > my G5 with Radeon 9600 Pro.
> > ok kirby@
> >
> > >>
> > >> Alex, if you had the issue and know what is needed to make glitches
> > >> disappear, we should add it to pkg/README :)
> > >>
> > >> OK cwen@ either way, here is the diff as we usually expect it by
> > >> the way.
> > >>
> > >> Charl?ne.
> > >>
> > >>
>
> [diff was here]
>
> > > Thank you all for informing me of how to submit things correctly. I
> > > greatly appreciate the correct format for the patches submitted
> > > here.
> > >
> > > As for the font issues, I only have one powerpc machine with
> > > graphics acceleration support in OpenBSD 6.7. Mach64 DRI was
> > > dropped years ago.
> > >
> > > My one machine has a Radeon 9200 32MB graphics card so I had to
> > > change the renderer to opengl1 in q3cfg.cfg using the text below.
> > >
> > > seta cl_renderer "opengl1"
> > >
> > > Also, fullscreen is scaled incorrectly on my card, it is in the
> > > corner of the screen and not completely visible. Windowed mode
> > > works fine, I have it set in q3cfg.cfg using the text below.
> > >
> > > seta r_fullscreen "0"
> > >
> > > As I believe we are using different renderers (9700 supports
> > > OpenGL2.0 AFAIK), maybe the opengl1 renderer will work better? I
> > > haven?t had any font issues on my OpenGL 1.3 card, just the
> > > fullscreen one which I work around by setting xrandr -s 640x480.
> > >
> > > Another thing I think might be important, on my radeon 9200 I have
> > > to use the fastest preset for a playable game. Resolution can be
> > > then be changed.
> > >
> > > Is this good to include in the readme? I can submit a new patch for
> > > an updated readme if that is what should be done next.
>
> I think we should add a subsection that details that. See
> /usr/ports/infrastructure/templates/README.template for the
> format we're using.
>
> It works 100% fine in fullscreen here with the standard configuration
> and:
>
> seta cl_renderer "opengl1"
> seta r_allowExtensions "0"
> seta r_hdr "0"
>
> I can get 40-ish fps with that. The tricky part when setting up
> graphics settings is to remember to use 32-bit depth and textures,
> otherwise it's a complete mess.
>
> I'm replying to your next mail while here:
>
> > Thank you all for testing and helping in the process. What's
> > the next step to get this into ports? Everything works as expected,
> > some graphics cards just need a few tweaks in the config file that
> > should be documented.
>
> Once we have a final diff that everyone agree upon, we've to wait for
> abieber@ that maintains the port to be OK with it/commit it.
>
>

I've created a patch for the readme, does it cover everything you had in mind and is it
done correctly?

Index: games/ioquake3/pkg/README
===================================================================
RCS file: /cvs/ports/games/ioquake3/pkg/README,v
retrieving revision 1.5
diff -u -p -u -r1.5 README
--- games/ioquake3/pkg/README 4 Sep 2018 12:46:13 -0000 1.5
+++ games/ioquake3/pkg/README 1 Jun 2020 03:16:56 -0000
@@ -19,3 +19,30 @@ rcctl enable ioq3ded && rcctl set ioq3de

For more information on the dedicated server see here:
http://wiki.ioquake3.org/Sys_Admin_Guide#Configuration_Files
+
+Macppc specifics
+================
+Additional configuration may be required, as noted below.
+
+OpenGL renderer
+---------------
+The opengl2 renderer is not available on many of the supported graphics cards and will prevent ioquake3 from starting with the default configuration. Specifiying seta cl_renderer "opengl1" in the config file will allow use of
+the opengl1 renderer.
+
+16-bit textures
+---------------
+Graphical issues occur when using 16-bit textures on the Radeon 9200, 9600, and 9700. 32-bit textures should be used if this happens.
+
+Radeon 9700
+-----------
+Weapons and fonts will not appear without specifying seta r_hdr "0" in the config file. The Radeon 9200 and 9600 do not have this issue.
+
+Extensions should also be turned off by specifying seta r_allowExtensions "0" in the config file.
+
+Radeon 9200
+-----------
+Fullscreen requires the X11 resolution to match the one specified in the ioquake3 config file. This has been tested in FVWM and Window Maker, and only Window Maker displays fullscreen correctly out of the 2.
+
+The fastest graphics preset should be used in ioquake3. Resolution can then be modifed from there for a playable game.
+
+The main menu in ioquake3 has poor performance that other parts of the game do not suffer from.