On 6/2/20 8:50 AM, Stuart Henderson wrote:
> On 2020/06/01 22:13, Brian Callahan wrote:
>> Hi Aisha --
>>
>> ‐‐‐‐‐‐‐ Original Message ‐‐‐‐‐‐‐
>> On Sunday, May 31, 2020 10:03 PM, Aisha Tammy <openbsd.ports@aisha.cc> wrote:
>>
>>> Hi,
>>>
>>> I've attached the port again, with a few more fixes.
>>>
>>> Would love to see this added.
>>>
>>> A few words about this port:
>>>
>>> It is a minimalistic pastebin client which allows you to also
>>>
>>> paste encrypted texts and has a simple javascript decryptor frontend.
>>>
>>> It is asynchronous and allows you to limit the paste size and a
>>>
>>> location where the pastes are stored.
>>>
>>> It uses unveil and pledge to make sure that only the necessary
>>>
>>> folders and permissions are used.
>>>
>>> Really hope this can be added and would love to get any advice about
>>>
>>> how to improve this port :)
>>>
>>> Aisha
>>
>> Thanks for the ports. I've attached improved versions of the ports
>> that address what I'll talk about in this email. I'll take each
>> separately.
>>
>> usockets:
>> * I see that it compiles with -std=c11, so we need to have a
>> COMPILER=base-clang ports-gcc line.
>> * The Makefile has some -O3 lines, so those go. It also has some -flto
>> lines. I don't believe all our archs can support -flto at the moment
>> so I removed them too.
>> * I am not sure why you create and install a shared version of this
>> library. It seems like upstream intends for this to be statically
>> linked into executables. Indeed, you don't even use the shared
>> version of the library in PurritoBin, so I think it can go.
>> * Your patch to the Makefile causes everything to be recompiled at
>> fake time.
>> * Not related to your port, but too bad that we are stuck using libuv
>> (it can use kqueue but it uses extensions from FreeBSD that we don't
>> have).
>>
>> uwebsockets:
>> * Upstream claims this is a web server so I moved the category to www.
>> Devel is quite full. Otherwise this port is quite straightforward.
>>
>> purritobin:
>> * Since you're using the static version of usocket, we can simplify
>> your depends lists.
>>
>> ~Brian
>>
>
>
>
>
> purritobin
> - Makefile:
> - add "uses pledge()" above wantlib as done in other ports
> - pkg/DESCR:
> - trailing blank line
> - s/writted/written
>
I've attached with the suggested fixes and those from Brian.
again, thank you Brian!
> All these static libraries mean that things won't get updated
> automatically when a library is updated. Say you install purritobin
> and there is a later security fix to usockets; purritobin won't be
> updated unless you manually force it (e.g. by bumping REVISION).
> The normal way of handling this with almost everything else in ports
> is to use shared libraries.
>
am not sure if there is a good fix for this (?!)
Aisha
No comments:
Post a Comment