Re: sparc64 bulk build report

On 2020/06/01 11:50, Solene Rapenne wrote:
> On Mon, 1 Jun 2020 10:42:03 +0100
> Stuart Henderson <stu@spacehopper.org>:
>
> > A summary of the failures:
> >
> > On 2020/06/01 02:30, kmos@openbsd.org wrote:
> > > http://build-failures.rhaalovely.net/sparc64/2020-05-29/games/wrath.log
> > >
> >
> > cc1: error: unrecognized command line option "-msse2"
>
> Is this because -msse2 doesn't exist on sparc64?

SSE/SSE2 only exist on i386/amd64. The code has support for building
without these but the makefile doesn't cope. This probably fixes it.

Index: Makefile
===================================================================
RCS file: /cvs/ports/games/wrath/Makefile,v
retrieving revision 1.1.1.1
diff -u -p -r1.1.1.1 Makefile
--- Makefile 25 May 2020 16:08:41 -0000 1.1.1.1
+++ Makefile 1 Jun 2020 10:21:37 -0000
@@ -24,6 +24,10 @@ MAKE_FLAGS = CC="${CC}" \
CFLAGS_LIBJPEG="-I${LOCALBASE}/include -DLINK_TO_LIBJPEG" \
CPUOPTIMIZATIONS="${CFLAGS}"

+.if !(${MACHINE_ARCH} == amd64 || ${MACHINE_ARCH} == i386)
+MAKE_FLAGS += CFLAGS_SSE= CFLAGS_SSE2=
+.endif
+
USE_GMAKE = Yes

NO_TEST = Yes

> There is no chance someone play this game on sparc64 even if it could
> run, it requires good graphics performance.
>
> would this be fine?
>
> Index: Makefile
> ===================================================================
> RCS file: /cvs/ports/games/wrath/Makefile,v
> retrieving revision 1.1.1.1
> diff -u -p -r1.1.1.1 Makefile
> --- Makefile 25 May 2020 16:08:41 -0000 1.1.1.1
> +++ Makefile 1 Jun 2020 09:50:22 -0000
> @@ -1,5 +1,7 @@
> # $OpenBSD: Makefile,v 1.1.1.1 2020/05/25 16:08:41 solene Exp $
>
> +BROKEN-sparc64 = cc1: error: unrecognized command line option "-msse2"
> +
> COMMENT = client of wrath-darkplaces engine
>
> DISTNAME = wrath-0.0.0.20200228

It will be broken on other archs too.

AFAIK the general policy is to build ports as long as they build even
if they are useless on an architecture. (I don't agree with that policy
but it is what we have done historically)... if that is not the case then
there are quite a lot of other ports that could be disabled to save time
in bulk builds :)