Re: new games/onscripter-en

Hi Nam --

On Friday, July 31, 2020 7:49 PM, Nam Nguyen <namn@berkeley.edu> wrote:

> Please find attached a new port for games/onscripter-en.
>
> onscripter-en is an English branch of onscripter to play NScripter and
> ONScripter games. These are typically visual novels.
>

Thanks for the port. I don't have any games to test, but I did a build
test and have some thoughts:

* You have that 20110628 number in both DISTNAME and PKGNAME, so it
should be spun out into its own variable (usually V).
* Is there any hope for the original web page to return? If not, I
think it makes more sense to either use the kaisernet site or a
snapshot from the wayback machine (like you do in pkg/README) for
the HOMEPAGE.
* For CONFIGURE_ENV, you want CC="${CC}" and CXX="${CXX}".
* Looking through the pkg/README, it seems like font/ja-sazanami-ttf
is effectively required. What do you think about adding it as an
RDEP?
* Running `make configure` it looks like there are x86(_64) specific
routines but they are not picked up because there is no test for
a platform named amd64. Something like the below will pick up amd64
and use the x86 specific graphics routines.

~Brian

$OpenBSD$

amd64 should also match x86_64.

Index: configure
--- configure.orig
+++ configure
@@ -291,7 +291,7 @@ esac
$echo_n " cpu type... ${nobr}"
ARCH=
case "$PLATFORM" in
-*86_64*) echo "x86_64"; ARCH=x86_64;;
+*amd64*|*86_64*) echo "x86_64"; ARCH=x86_64;;
*86*) ARCH=`expr "x$PLATFORM" : 'x\(.*86\).*'`; \
echo "$ARCH";;
*powerpc*) echo "PowerPC"; ARCH=ppc;;