bijan <bijanebrahimi@riseup.net> writes:
> Hi,
> This is a patch to create new port textproc/peg-markdown[1].
>
> The port tries to install it's binary as markdown. I don't
> know if it conflicts with other packages and should I rename
> the binary or not? Since this is my first attempt to port a new
> software, I would appreciate it if somebody can educate me on
> this one.
>
> Thanks.
>
> [1]: https://github.com/jgm/peg-markdown
Hi,
I found the port name interesting, so I took a look. Some quick notes:
- when using GH_* variables you don't need to define also MASTER_SITES
- portcheck (/usr/ports/infrastructure/bin/portcheck) complains about
trailing whitespaces in Makefile
- devel/gettext,-runtime and devel/glib2 are missing as LIB_DEPENDS
(make port-lib-depends-check complained about them), and in turns
they also need to be added to WANTLIB. (make port-lib-depends-check
will help here)
- the readme says that GCC is needed to build the bundled peg library,
and in fact it's hardcoded. The COMPILER should be adapted (I
believe it should read `base-gcc ports-gcc' but I'm not 100% sure).
Also, when it builds the peg library the CFLAGS aren't propagated, so
the Makefile should be patched.
- (but this is a personal opinion) I find strange that the package
`peg-markdown' install the `markdown' executable.
other than that, it runs here :)
No comments:
Post a Comment