Hello,
I tested your patch with my setup and everything works OK for me.
* Balances
* Budgets
* Commodities
* Multiple-file inclusion
All of the above work OK.
I don't know if it's too late to get in for 6.8 because of the
ports lock, but whether it goes in now or later, I didn't see any
regressions for any of my use cases.
--
Bryan
On 2020-09-28 14:55:05, Martin Ziemer <horrad@horrad.de> wrote:
> I hope, i am not too late, but i would really like to see the bug in
> ledger fixed for next -stable. (I run 3.2.1 since Aug 25 on all my four
> amd64 machines with no problems and before there were the crashes mentioned
> in github as #1850)
>
> On Wed, Sep 09, 2020 at 10:57:04AM +0200, Martin Ziemer wrote:
> > On Tue, Aug 25, 2020 at 12:29:26PM +0200, Martin Ziemer wrote:
> > > On Tue, Aug 25, 2020 at 10:06:29AM +0100, Stuart Henderson wrote:
> > > > On 2020/08/25 10:56, Martin Ziemer wrote:
> > > > > This patch updates ledger from v3.1.3 to v3.2.1
> > > >
> > > > > +MODPY_VERSION = ${MODPY_DEFAULT_VERSION_3}
> > > > ^^^^^^^^^
> > > > please mind spaces vs tabs
> > > I changed the spaces to tabs in the diff below.
> > >
> > > > Otherwise OK with me (I don't use this though so can't do any meaningful
> > > > testing).
> > > Testing is in my case using my private ledger, which has around 9000
> > > entries as of today. I have also some scripts, which interact with ledger.
> >
> > Since the mail from 2020-08-25 there was no feedback from the
> > maintainer.
> >
> > I used the new version since then on three amd64 systems at least every
> > second day. (One system each day)
> >
> > I would really like to get the new version in, as it fixes some
> > regexp-based segfaults in our current version (bug #1850 in github).
>
>
> Index: Makefile
> ===================================================================
> RCS file: /cvs/ports/productivity/ledger/Makefile,v
> retrieving revision 1.28
> diff -u -p -u -p -r1.28 Makefile
> --- Makefile 22 Dec 2019 16:05:42 -0000 1.28
> +++ Makefile 25 Aug 2020 09:12:19 -0000
> @@ -2,7 +2,7 @@
>
> COMMENT = command line double-entry accounting ledger
>
> -GH_TAGNAME = v3.1.3
> +GH_TAGNAME = v3.2.1
> GH_ACCOUNT = ledger
> GH_PROJECT = ledger
>
> @@ -23,6 +23,7 @@ WANTLIB += c gmp icuuc m mpfr pthread ${
>
> MODULES = devel/cmake \
> lang/python
> +MODPY_VERSION = ${MODPY_DEFAULT_VERSION_3}
> COMPILER = base-clang ports-gcc
>
> BUILD_DEPENDS = devel/utfcpp
> @@ -57,7 +58,5 @@ post-install:
> .for d in LICENSE.md doc/GLOSSARY.md
> ${INSTALL_DATA} ${WRKSRC}/$d ${PREFIX}/share/doc/ledger/
> .endfor
> - ${INSTALL_DATA_DIR} ${PREFIX}/share/examples/ledger
> - cd ${WRKSRC}/contrib && umask 022 && pax -rw . ${PREFIX}/share/examples/ledger
>
> .include <bsd.port.mk>
> Index: distinfo
> ===================================================================
> RCS file: /cvs/ports/productivity/ledger/distinfo,v
> retrieving revision 1.7
> diff -u -p -u -p -r1.7 distinfo
> --- distinfo 22 Dec 2019 16:05:42 -0000 1.7
> +++ distinfo 25 Aug 2020 09:12:19 -0000
> @@ -1,2 +1,2 @@
> -SHA256 (ledger-3.1.3.tar.gz) = skjJHWXHoQG51iJgJfK0vz2r6UwMSattUc6Eoio5Yis=
> -SIZE (ledger-3.1.3.tar.gz) = 800880
> +SHA256 (ledger-3.2.1.tar.gz) = kr8JvDhbFxmH9Fb+Pun6mY7V5AuXs6zdVitmOqNkOEo=
> +SIZE (ledger-3.2.1.tar.gz) = 790959
> Index: pkg/PLIST
> ===================================================================
> RCS file: /cvs/ports/productivity/ledger/pkg/PLIST,v
> retrieving revision 1.5
> diff -u -p -u -p -r1.5 PLIST
> --- pkg/PLIST 22 Dec 2019 16:05:42 -0000 1.5
> +++ pkg/PLIST 25 Aug 2020 09:12:19 -0000
> @@ -65,73 +65,3 @@ info/ledger3.info
> share/doc/ledger/
> share/doc/ledger/GLOSSARY.md
> share/doc/ledger/LICENSE.md
> -share/examples/ledger/
> -share/examples/ledger/CSVReader.cs
> -share/examples/ledger/Makefile
> -share/examples/ledger/ParseCcStmt.cs
> -share/examples/ledger/README
> -share/examples/ledger/bal
> -share/examples/ledger/bal-huquq
> -share/examples/ledger/compilation-ledger.el
> -share/examples/ledger/entry
> -share/examples/ledger/getquote-uk.py
> -share/examples/ledger/getquote.pl
> -share/examples/ledger/iso4127-commodities/
> -share/examples/ledger/iso4127-commodities/iso4217ledger.sh
> -share/examples/ledger/iso4127-commodities/iso4217ledger.xsl
> -share/examples/ledger/ledger-completion.bash
> -share/examples/ledger/ledger-du
> -share/examples/ledger/non-profit-audit-reports/
> -share/examples/ledger/non-profit-audit-reports/GPLv3
> -share/examples/ledger/non-profit-audit-reports/LICENSE
> -share/examples/ledger/non-profit-audit-reports/README
> -share/examples/ledger/non-profit-audit-reports/bank-reconcilation.plx
> -share/examples/ledger/non-profit-audit-reports/cash-receipts-and-disbursments-journals.plx
> -share/examples/ledger/non-profit-audit-reports/csv2ods.py
> -share/examples/ledger/non-profit-audit-reports/demo.sh
> -share/examples/ledger/non-profit-audit-reports/fund-report.plx
> -share/examples/ledger/non-profit-audit-reports/general-ledger-report.plx
> -share/examples/ledger/non-profit-audit-reports/ooolib2/
> -share/examples/ledger/non-profit-audit-reports/ooolib2/__init__.py
> -share/examples/ledger/non-profit-audit-reports/readcsv.py
> -share/examples/ledger/non-profit-audit-reports/summary-reports.plx
> -share/examples/ledger/non-profit-audit-reports/tests/
> -share/examples/ledger/non-profit-audit-reports/tests/Financial/
> -share/examples/ledger/non-profit-audit-reports/tests/Financial/BankStuff/
> -share/examples/ledger/non-profit-audit-reports/tests/Financial/BankStuff/bank-statement.pdf
> -share/examples/ledger/non-profit-audit-reports/tests/Financial/Invoices/
> -share/examples/ledger/non-profit-audit-reports/tests/Financial/Invoices/Invoice20110510.pdf
> -share/examples/ledger/non-profit-audit-reports/tests/Financial/Invoices/Invoice20110510.txt
> -share/examples/ledger/non-profit-audit-reports/tests/Projects/
> -share/examples/ledger/non-profit-audit-reports/tests/Projects/Blah/
> -share/examples/ledger/non-profit-audit-reports/tests/Projects/Blah/Expenses/
> -share/examples/ledger/non-profit-audit-reports/tests/Projects/Blah/Expenses/hosting/
> -share/examples/ledger/non-profit-audit-reports/tests/Projects/Blah/Expenses/hosting/AprilHostingReceipt.pdf
> -share/examples/ledger/non-profit-audit-reports/tests/Projects/Blah/Expenses/hosting/april-invoice.pdf
> -share/examples/ledger/non-profit-audit-reports/tests/Projects/Foo/
> -share/examples/ledger/non-profit-audit-reports/tests/Projects/Foo/Expenses/
> -share/examples/ledger/non-profit-audit-reports/tests/Projects/Foo/Expenses/hosting/
> -share/examples/ledger/non-profit-audit-reports/tests/Projects/Foo/Expenses/hosting/AprilHostingReceipt.pdf
> -share/examples/ledger/non-profit-audit-reports/tests/Projects/Foo/Expenses/hosting/AprilHostingReceipt.txt
> -share/examples/ledger/non-profit-audit-reports/tests/Projects/Foo/Invoices/
> -share/examples/ledger/non-profit-audit-reports/tests/Projects/Foo/Invoices/Invoice20100101.pdf
> -share/examples/ledger/non-profit-audit-reports/tests/Projects/Foo/earmark-record.txt
> -share/examples/ledger/non-profit-audit-reports/tests/non-profit-test-data.ledger
> -share/examples/ledger/non-profit-audit-reports/tests/non-profit-test-data_MANIFEST
> -share/examples/ledger/non-profit-audit-reports/tests/non-profit-test-data_chart-of-accounts.csv
> -share/examples/ledger/non-profit-audit-reports/tests/non-profit-test-data_general-ledger.ods
> -share/examples/ledger/non-profit-audit-reports/unpaid-accruals-report.plx
> -share/examples/ledger/raw/
> -share/examples/ledger/raw/GenerateLatexExpeneseReport.pl
> -share/examples/ledger/raw/MetadataExample.dat
> -share/examples/ledger/raw/README
> -share/examples/ledger/raw/VerifyImages.sh
> -share/examples/ledger/raw/dotemacs.el
> -share/examples/ledger/raw/ledger-matching.el
> -share/examples/ledger/raw/ledger-shell-environment-functions
> -share/examples/ledger/repl.sh
> -share/examples/ledger/report
> -share/examples/ledger/tc
> -share/examples/ledger/ti
> -share/examples/ledger/to
> -share/examples/ledger/trend
>
>
No comments:
Post a Comment