Monday, October 05, 2020

[new] archivers/minizip

Hi,

here's a port for minizip, taken from
https://github.com/nmoinvaz/minizip - minizip was originally in the
contrib/ subdir of zlib, then moved to
https://www.winimage.com/zLibDll/minizip.html, then more or less died
there, and then got a new upstream on github (that everyone seems to
point at).

of course, given there are several upstreams, some projects bundle one
version, some projects bundle the other, some allow to build against a
systemwide version, etc... and ofc i need this for an upcoming update to
geo/spatialite (among other new ports i'll send later).

debian packages the dead version (per
https://packages.debian.org/search?keywords=minizip), redhat/fedora packages the new version
(per
https://lists.fedoraproject.org/archives/list/devel@lists.fedoraproject.org/thread/YSPZUBTKN6T5TTUZW5NOWUW7VBIRCOZY/)

Ports-wise, its patched to install headers under include/minizip as it
seems that's what everyone does to avoid conflicts with
archivers/libzip. I havent enabled zstd and lzma because iirc those were
not building ootb (iirc it tried fetching zstd sources, and the bundled
lzma is modified...)

after looking on the interwebs (thanks debian codesearch..) seems this
can have impact on:

* multimedia/assimp, given https://github.com/assimp/assimp/issues/2121
iand after testing it's better to disable building against external -
CONFIGURE_ARGS+=-DASSIMP_BUILD_MINIZIP:bool=true fixes that

* emulators/mupen64plus/core: detects it, builds & links against it.
Dependency/WANTLIB needs adjustment. easy one.

* editors/wordgrinder: bundles a copy, default to build its copy

* games/widelands: bundles a copy, hardcodes it

* x11/qt5/qtwebengine: detects it during configure, and if found fails
hard because the APIs dont match. i will probably disable the detection,
as this bundles chromium code which bundles two different copies of
minizip, one in zlib and one in minizip. I'm not surprised there.
still testing a patch..

* chromium probably has the same problem. Not sure i want to build
chrome to figure that out :)

* geo/gpsbabel had some kind of support for it (HAVE_LIBMINIZIP) but it
was removed per https://github.com/gpsbabel/gpsbabel/pull/382

So what do ppl think ? import this version, fixing bits here and there ?
not do anything ? import the dead debian version ?

Landry

No comments:

Post a Comment