Re: Remove textproc/glimpse?

Hi Klemens,

Klemens Nanni wrote on Sat, Oct 03, 2020 at 02:21:42AM +0200:
> On Sun, Sep 20, 2020 at 02:48:26PM +0200, Ingo Schwarze wrote:

>> Judging from patch-Makefile, it ought to be trivial to remove the
>> dependency on glimpse.

> True, so let's do that and keep the port as you outlined potential use
> for it.
> Feedback? OK?

OK schwarze@, this is already a clear improvement.


After this, more work should be done:

* Remove the hidden dependency on textproc/groff and use mandoc(1)
instead. Fixing patch-Makefile is probably sufficient to achieve
that.

So far, i did not investigate how the following can be achieved,
but they are clearly needed and i'd be surprised if they were hard:

* Remove the requirement to set MANPATH.
Use the default instead.
Or even better, use /etc/man.conf if feasible.
* Remove the warning that the "whatis" file is missing
* Remove warning about stray cats
* And probably more.

Also, there *are* formatting problem with the output the program
produces, for example with respect to line breaks.

So there is still a lot of work to do, but even without all that,
the port is already partially useable.

Yours,
Ingo


> Index: Makefile
> ===================================================================
> RCS file: /cvs/ports/misc/tkman/Makefile,v
> retrieving revision 1.26
> diff -u -p -r1.26 Makefile
> --- Makefile 12 Jul 2019 20:47:54 -0000 1.26
> +++ Makefile 3 Oct 2020 00:14:57 -0000
> @@ -3,7 +3,7 @@
> COMMENT = Tcl/Tk-based manual browser
>
> DISTNAME = tkman-2.2
> -REVISION = 0
> +REVISION = 1
> CATEGORIES = misc
> HOMEPAGE = http://www.sourceforge.net/projects/tkman
> MAINTAINER = Stuart Cassoff <stwo@users.sourceforge.net>
> @@ -15,8 +15,7 @@ MASTER_SITES = ${MASTER_SITE_SOURCEFORGE
> MODULES = x11/tk
>
> RUN_DEPENDS = ${MODTK_RUN_DEPENDS} \
> - textproc/rman \
> - textproc/glimpse
> + textproc/rman
>
> NO_TEST = Yes
>
> Index: patches/patch-Makefile
> ===================================================================
> RCS file: /cvs/ports/misc/tkman/patches/patch-Makefile,v
> retrieving revision 1.4
> diff -u -p -r1.4 patch-Makefile
> --- patches/patch-Makefile 5 Jan 2011 17:34:17 -0000 1.4
> +++ patches/patch-Makefile 3 Oct 2020 00:19:14 -0000
> @@ -1,6 +1,7 @@
> $OpenBSD: patch-Makefile,v 1.4 2011/01/05 17:34:17 stu Exp $
> ---- Makefile.orig Fri Dec 10 19:26:34 2010
> -+++ Makefile Fri Dec 10 19:35:54 2010
> +Index: Makefile
> +--- Makefile.orig
> ++++ Makefile
> @@ -25,7 +25,7 @@ mintk = 8.4
>
> ### you need to localize the paths on these lines
> @@ -57,25 +58,16 @@ $OpenBSD: patch-Makefile,v 1.4 2011/01/0
> # printing string for preformatted pages without [tn]roff source
> #catprint = lpr
> #catprint = "lpr -h"
> -@@ -201,14 +201,15 @@ shortnames = 0
> - # the right-topmost menu's Rebuild Database/Glimpse Index menu choice.
> -
> +@@ -203,7 +203,7 @@ shortnames = 0
> # BY DEFAULT OFF
> --glimpse = ""
> -+#glimpse = ""
> + glimpse = ""
> # Glimpse on, with Boolean scope set to entire file
> -glimpse = "glimpse -W"
> +#glimpse = "glimpse -W"
> # give the full path, if you'd like
> #glimpse = /usr/sww/bin/glimpse
> # variations (refer to the Glimpse manual page)
> - # no characters treated as meta characters:
> - #glimpse = "glimpse -Wk"
> -+glimpse = "glimpse -z"
> - # compressed manual pages are handled automatically; don't add -z to above
> -
> - # glimpseindex indexes the manual pages, for each component of one's MANPATH,
> -@@ -460,7 +461,7 @@ install: tkman retkman
> +@@ -460,7 +460,7 @@ install: tkman retkman
> chmod +rx $(BINDIR)/tkman
> $(CP) retkman $(BINDIR)
> chmod +rx $(BINDIR)/retkman