Sunday, October 04, 2020

Re: Review for cabal.port.mk

Sebastien Marie <semarie@online.fr> writes:

> On Sun, Oct 04, 2020 at 09:56:22AM +0200, Marc Espie wrote:
>> I'll have to look more closely, but I have a few concerns.
>>
>> On Sat, Oct 03, 2020 at 11:03:43PM -0700, Greg Steuck wrote:
>> > MASTER_SITES0 = https://hackage.haskell.org/package/
>> That's a minor one.
>> This sets a precedent of hijacking a MASTER_SITESn for a specific module.
>> I don't think it's a big concern because cabal is somewhat isolated.
>> We'll deal with that if we must.
>
> just a side note.
>
> technically lang/rust and lang/go already do something like that, but
> in a more flexible way: the number is configurable, and by default is
> a high number (9) to limit conflict with possible user usage.

I'm happy to switch to 9. I'm reticent to introduce a knob considering
neither MODGO_MASTER_SITESN nor MODCARGO_MASTER_SITESN attracted any
usage I could find. The latter has been around for 4 years. YAGNI?

Thanks
Greg

No comments:

Post a Comment