Re: [New] devel/fmt

On Mon, Nov 09 2020, Ashton Fagg <ashton@fagg.id.au> wrote:
> Jeremie Courreges-Anglas <jca@wxcvbn.org> writes:
>
>> Here are some items that need fixing:

tl;dr everything looks good except WANTLIB.

[...]

>> * WANTLIB is off, don't copy/paste it from other ports. You can just
>> copy/paste the suggested WANTLIB line(s) from make
>> port-lib-depends-check, with no editing:
>>
>> --8<--
>> russell /usr/ports/mystuff/devel/fmt$ make port-lib-depends-check
>>
>> fmt-7.1.1(devel/fmt):
>> Extra: pthread.26
>> russell /usr/ports/mystuff/devel/fmt$ make show=COMPILER_LIBCXX
>> c++ c++abi pthread
>> -->8--
>>
>> Dunno why libfmt isn't linked against libpthread here, but the suggested
>> WANTLIB is almost certainly correct.
>
> Addressed.

You have this line:

WANTLIB+= c++ c++abi ${COMPILER_LIBCXX}

"c++ c++abi" *is* the content of COMPILER_LIBCXX when you use
base-clang, so no need to duplicate it. The contents of COMPILER_LIBCXX
will change according to the compiler used.

So the line should be just WANTLIB = ${COMPILER_LIBCXX}, this is fixed
in the updated tarball attached, I also moved WANTLIB to follow
Makefile.template ordering and s/+=/=/ for CONFIGURE_ARGS (because
there's no technical reason to use += here, the variable isn't set at
that point).