Re: UPDATE: LLVM - Fix building on arm

On Tue, Nov 03 2020, Brad Smith <brad@comstyle.com> wrote:
> The following diff fixes building the LLVM port on arm.

http://build-failures.rhaalovely.net/arm/2020-06-03/devel/llvm,,-main.log

Is it supposed to fix this error? What was the problem?

> pickles$ make install
> ===> Verifying specs: c++ c++abi pthread c edit m pthread z
> ===> found c++.5.0 c++abi.3.0 pthread.26.1 c.96.0 edit.5.2 m.10.1 z.5.0
> ===> Installing llvm-10.0.1p3 from /usr/ports/packages/arm/all/
> llvm-10.0.1p3: ok
> New and changed readme(s):
> /usr/local/share/doc/pkg-readmes/llvm
> pickles$ /usr/local/bin/clang --version
> clang version 10.0.1
> Target: arm-unknown-openbsd6.8
> Thread model: posix
> InstalledDir: /usr/local/bin
>
>
> Index: Makefile
> ===================================================================
> RCS file: /home/cvs/ports/devel/llvm/Makefile,v
> retrieving revision 1.263
> diff -u -p -u -p -r1.263 Makefile
> --- Makefile 4 Sep 2020 09:55:35 -0000 1.263
> +++ Makefile 3 Nov 2020 17:48:10 -0000
> @@ -109,10 +109,7 @@ CXXFLAGS += -fno-ret-protector
> CXXFLAGS += -mno-retpoline
> .endif
>
> -.if ${MACHINE_ARCH} == "arm"
> -CFLAGS += -mlong-calls
> -CXXFLAGS += -mlong-calls
> -.elif ${MACHINE_ARCH} == "powerpc"
> +.if ${MACHINE_ARCH} == "powerpc"
> CONFIGURE_ARGS += -DCMAKE_EXE_LINKER_FLAGS="-Wl,-relax"
> CONFIGURE_ARGS += -DCMAKE_SHARED_LINKER_FLAGS="-Wl,-relax"
> .endif
>

--
jca | PGP : 0x1524E7EE / 5135 92C1 AD36 5293 2BDF DDCC 0DFA 74AE 1524 E7EE