Re: UPDATE net/radcli-1.3.0

On Thu 12/11/2020 20:46, Stuart Henderson wrote:
> On 2020/11/12 21:40, Bjorn Ketelaars wrote:
> > Diff below updates radcli to 1.3.0. From
> > https://github.com/radcli/radcli/releases/tag/1.3.0:
> > - Removed duplicate function definition from util.h (#53)
> > - Increased size of dictionary vendor and values to 32-bits from 16;
> > this breaks the ABI from the previous release.
> > - Corrected a string termination issue in rc_avpair_tostr()
> > - Added functions to create dictionary without a file: rc_dict_addattr,
> > rc_dict_addval, rc_dict_addvend
> >
> > Changes to port:
> > - Bump major of SHARED_LIB accordingly
> > - While here move HOMEPAGE to https and sync WANTLIB
> >
> > Comments/OK?
>
> > -V= 1.2.11
> > +GH_TAGNAME= 1.3.0
>
> Diff needs a refresh, I updated this to 1.2.12 earlier (I didn't go
> straight for 1.3.0 because I thought I'd wait and see if they added a
> proper tarball with generated configure script first :)

New diff in case upstream does not release a proper tarball...


Index: Makefile
===================================================================
RCS file: /cvs/ports/net/radcli/Makefile,v
retrieving revision 1.13
diff -u -p -r1.13 Makefile
--- Makefile 12 Nov 2020 17:00:06 -0000 1.13
+++ Makefile 12 Nov 2020 20:52:42 -0000
@@ -2,28 +2,31 @@

COMMENT= simple RADIUS client library

-SHARED_LIBS += radcli 0.3 # 6.0
+SHARED_LIBS += radcli 1.0 # 8.0

-V= 1.2.12
-DISTNAME= radcli-$V
+GH_ACCOUNT= radcli
+GH_PROJECT= radcli
+GH_TAGNAME= 1.3.0

CATEGORIES= net

-HOMEPAGE= http://radcli.github.io/radcli/
+HOMEPAGE= https://radcli.github.io/radcli/

# recent code BSD, some old MERIT/Livingston
PERMIT_PACKAGE= Yes

-WANTLIB = ffi gmp gnutls hogweed iconv idn2 intl nettle p11-kit pthread
-WANTLIB += tasn1 unistring z
-
-MASTER_SITES= https://github.com/radcli/radcli/releases/download/$V/
+WANTLIB += ffi gmp gnutls hogweed iconv idn2 intl nettle p11-kit
+WANTLIB += pthread tasn1 unistring

LIB_DEPENDS= security/gnutls

FAKE_FLAGS= pkgsysconfdir=${PREFIX}/share/examples/radcli

-CONFIGURE_STYLE= gnu
+CONFIGURE_STYLE= autoreconf
+
+AUTOCONF_VERSION= 2.69
+AUTOMAKE_VERSION= 1.15
+AUTORECONF= ./autogen.sh

# most tests need a running local RADIUS server; they talk about a
# run-server.sh script to run this but it's not actually included.
Index: distinfo
===================================================================
RCS file: /cvs/ports/net/radcli/distinfo,v
retrieving revision 1.8
diff -u -p -r1.8 distinfo
--- distinfo 12 Nov 2020 17:00:06 -0000 1.8
+++ distinfo 12 Nov 2020 20:52:42 -0000
@@ -1,2 +1,2 @@
-SHA256 (radcli-1.2.12.tar.gz) = +hRo/vlDDTi4ADX+kmljVFqJj7h1GVzT7im65w0DAak=
-SIZE (radcli-1.2.12.tar.gz) = 597289
+SHA256 (radcli-1.3.0.tar.gz) = HX/6+feMGL9cY0iySRvh7hc5AXJjb6h713GdZpy0b68=
+SIZE (radcli-1.3.0.tar.gz) = 246802
Index: patches/patch-lib_util_h
===================================================================
RCS file: /cvs/ports/net/radcli/patches/patch-lib_util_h,v
retrieving revision 1.2
diff -u -p -r1.2 patch-lib_util_h
--- patches/patch-lib_util_h 19 Mar 2016 19:59:35 -0000 1.2
+++ patches/patch-lib_util_h 12 Nov 2020 20:52:42 -0000
@@ -1,7 +1,8 @@
$OpenBSD: patch-lib_util_h,v 1.2 2016/03/19 19:59:35 sthen Exp $
---- lib/util.h.orig Thu Nov 26 21:12:12 2015
-+++ lib/util.h Sat Mar 19 19:57:09 2016
-@@ -23,7 +23,9 @@ size_t rc_strlcpy(char *dst, char const *src, size_t s
+Index: lib/util.h
+--- lib/util.h.orig
++++ lib/util.h
+@@ -25,7 +25,9 @@ size_t rc_strlcpy(char *dst, char const *src, size_t s
#define SA_LEN(sa) \
(((sa)->sa_family == AF_INET) ? \
sizeof(struct sockaddr_in) : sizeof(struct sockaddr_in6))