Re: wg - panic: noise_keypair: lock not held

‐‐‐‐‐‐‐ Original Message ‐‐‐‐‐‐‐
On Wednesday, 4 November 2020 16:56, Caspar Schutijser <caspar@schutijser.com> wrote:

> On Mon, Nov 02, 2020 at 02:55:55PM +0000, Laura Smith wrote:
>
> > Hi
> > I'm still trying to figure out what triggered this, I think it might have been running "sh /etc/netstart" after a "hostname.wg" config update, but I've been unable to reproduce.
> > As a sidenote, I thought "ddb.panic=0" was supposed to prevent these sort of hanging panics?
> > Nonetheless, I'm pasting the trace here just incase its useful for someone :
> > panic: noise_keypair: lock not held
> > Starting stack trace...
> > panic (ffffffff81dbfe3d) at panic +0x11d
> > rw_exit_write(ffff800008017450) at rw_exit_write+0xb5
> > noise_remote_begin_session(ffff8000008017350) at  noise_remote_begin_session+0x3c1rw_exit_write(ffff800008017320) at wg_send_response+0x7b
> > wg_handshake(ffff800005ed00,ffffd80a7311600) at wg_handshake+0x576
> > wg_handshake_worker(ffff8000005ed000) at wg_handshake_worker+0x48
> > taskq_thread(ffff80000006d900) at taskq_thread+0x81
> > end trace frame:0x0, count:250
> > End of stack trace
>
> A fix for this has been committed, see
> https://marc.info/?l=openbsd-cvs&m=160415334131043&w=2
>
> A patch for OpenBSD 6.8 also exists:
> https://ftp.openbsd.org/pub/OpenBSD/patches/6.8/common/004_wg.patch.sig


Thanks Caspar. Indeed, Gabrial Kihlman kindly pointed out the patch, but because I only run -stable in production, I was without the fix. But the devs have kindly pushed it out as an Errata now so its all sorted and life is good again with wg(4) !