Monday, December 07, 2020

Re: new gortr port

Claudio Jeker writes:

> This is a probably very dirty port of gortr (a RPKI to Router server).
> gortr is able to serve rpki-client JSON files to routers via RTR protocol.

Not too dirty!

- MODGO_MODFILES can be removed since _MODULES adds both the .zip and
the .mod files to DISTFILES.

- The MODGO_GOPATH= and PKGNAME= lines can also be removed. (This leaves
$V dangling - personally I'd ditch it in favor of just setting
MODGO_VERSION).

I am not sure why things aren't picking up v0.14.7.. Looking at
https://proxy.golang.org/github.com/cloudflare/gortr/@latest points to
it being an issue on the Go side of things since
https://proxy.golang.org/github.com/cloudflare/gortr/@v/list lists
v0.14.7..

I have a diff that lets one pass a version number to
modgo-gen-modules-helper. This lets us grab the MODGO_* bits for a
specific version despite what proxy.golang.org things IsRight[TM].

I'll dust that diff off here in a bit.

Other then the nits above, OK abieber@ for import.

>
> I doubt the MODGO settings are correct but for me
> make modgo-gen-modules
> fails with
>
> Use of uninitialized value in concatenation (.) or string at
> /usr/ports/infrastructure/bin/modgo-gen-modules-helper line 44.
> MODGO_MODFILES =

This happens because the port has no MODGO_MODFILES. This diff fixes it:

No comments:

Post a Comment