Re: update net/libtorrent-rasterbar 1.2.11

On Mon Dec 28, 2020 at 04:04:42AM -0800, Nam Nguyen wrote:
> Here is a diff to update libtorrent-rasterbar to 1.2.11, released on
> Nov. 15, 2020.
>
> changelog: https://github.com/arvidn/libtorrent/releases/tag/v1.2.11
>
> This diff:
> - bumps library major due to symbol deprecation
> - changes MASTER_SITES to properly download the new release
>
> I tested with qbittorrent and deluge. `make test' skips the same tests
> as the previous release (test_lsd and test_primitives).
>
> OK?

It has built cleanly and port-wise it looks fine. OK rsadowski@

>
> Details
> =======
> I highlight 3 changelog items to show why a major bump is needed.
>
> 1. deprecate torrent_status::allocating. This state is no longer used
>
> allocating is now marked as deprecated to throw a warning, so this is
> sufficient to justify a major bump.
>
> include/libtorrent/torrent_status.hpp:125:
> allocating TORRENT_DEPRECATED_ENUM,
>
> include/libtorrent/aux_/deprecated.hpp:43:
> # define TORRENT_DEPRECATED_ENUM __attribute__ ((deprecated))
>
> 2. torrent.hpp allow saving resume data before metadata has been
> downloaded (for magnet links)
>
> https://github.com/arvidn/libtorrent/commit/45c1219c8433a4af5193377b4b07d6258faa3ad7
>
> write_resume_data inside include/libtorrent/torrent.hpp changed its
> function signature so this can also justify a major bump.
>
> from 1.2.10: void write_resume_data(add_torrent_params& atp) const;
> from 1.2.11: write_resume_data(resume_data_flags_t const flags, add_torrent_params& ret) const;
>
> 3. add session::paused flag, and the ability to construct a session in
> paused mode
>
> https://github.com/arvidn/libtorrent/commit/9bfbee334e421e48a32d0a9780136cca36890a75
>
> New exposed flag justifies a minor bump.
>
> Index: Makefile
> ===================================================================
> RCS file: /cvs/ports/net/libtorrent-rasterbar/Makefile,v
> retrieving revision 1.13
> diff -u -p -r1.13 Makefile
> --- Makefile 7 Sep 2020 04:24:17 -0000 1.13
> +++ Makefile 28 Dec 2020 11:42:07 -0000
> @@ -2,10 +2,10 @@
>
> COMMENT = C++ library implementing a BitTorrent client
>
> -MODPY_EGG_VERSION = 1.2.10
> +MODPY_EGG_VERSION = 1.2.11
> DISTNAME = libtorrent-rasterbar-${MODPY_EGG_VERSION}
>
> -SHARED_LIBS += torrent-rasterbar 3.0 # 10.0.0
> +SHARED_LIBS += torrent-rasterbar 4.0 # 10.0.0
>
> CATEGORIES = net devel
>
> @@ -17,7 +17,7 @@ PERMIT_PACKAGE = Yes
> WANTLIB += ${COMPILER_LIBCXX} boost_python${MODPY_VERSION:C/\.//g}-mt
> WANTLIB += boost_system-mt crypto iconv m ssl
>
> -MASTER_SITES = https://github.com/arvidn/libtorrent/releases/download/libtorrent-${MODPY_EGG_VERSION}/
> +MASTER_SITES = https://github.com/arvidn/libtorrent/releases/download/v${MODPY_EGG_VERSION}/
>
> MODULES = lang/python
> MODPY_VERSION = ${MODPY_DEFAULT_VERSION_3}
> Index: distinfo
> ===================================================================
> RCS file: /cvs/ports/net/libtorrent-rasterbar/distinfo,v
> retrieving revision 1.8
> diff -u -p -r1.8 distinfo
> --- distinfo 7 Sep 2020 04:24:17 -0000 1.8
> +++ distinfo 28 Dec 2020 11:42:07 -0000
> @@ -1,2 +1,2 @@
> -SHA256 (libtorrent-rasterbar-1.2.10.tar.gz) = 0N0wvcOSZYfEJB9AaNjjliimwfn2z1MZXw6byQAXvvs=
> -SIZE (libtorrent-rasterbar-1.2.10.tar.gz) = 4128498
> +SHA256 (libtorrent-rasterbar-1.2.11.tar.gz) = y2qcw8mp5IUXQ5S6qCdEzvhBXSOjV/VyHcye52IsTvs=
> +SIZE (libtorrent-rasterbar-1.2.11.tar.gz) = 4138173
>