Re: games/ace: -fno-common fix

On Sun, Jan 31, 2021 at 01:30:19PM +0100, Charlene Wendling wrote:
> Hi,
>
> This fix has been taken from FreeBSD [0]. check_sym reports no dynamic
> change. This has been built and tested successfully on macppc and amd64.
>
> OK?

Is a revision bump strictly needed for this?

ok jsg@

>
> Charlène.
>
>
> [0] https://github.com/freebsd/freebsd-ports/commit/53cdc659
>
>
> Index: Makefile
> ===================================================================
> RCS file: /cvs/ports/games/ace/Makefile,v
> retrieving revision 1.5
> diff -u -p -u -p -r1.5 Makefile
> --- Makefile 2 Oct 2019 21:11:08 -0000 1.5
> +++ Makefile 31 Jan 2021 12:18:00 -0000
> @@ -3,7 +3,7 @@
> COMMENT = solitaire games
>
> DISTNAME = ace-1.4
> -REVISION = 1
> +REVISION = 2
>
> SHARED_LIBS += cards 0.0 # 1.0
>
> Index: patches/patch-lib_table_c
> ===================================================================
> RCS file: patches/patch-lib_table_c
> diff -N patches/patch-lib_table_c
> --- /dev/null 1 Jan 1970 00:00:00 -0000
> +++ patches/patch-lib_table_c 31 Jan 2021 12:18:00 -0000
> @@ -0,0 +1,16 @@
> +$OpenBSD$
> +
> +Fix the build with -fno-common
> +
> +Index: lib/table.c
> +--- lib/table.c.orig
> ++++ lib/table.c
> +@@ -57,7 +57,7 @@ static int ex=0, ey=0, ew=0, eh=0;
> + static int graphics_disabled = 1;
> +
> + OptionDesc *app_options;
> +-OptionDesc *xwin_options;
> ++extern OptionDesc *xwin_options;
> + static OptionDesc *options[5];
> +
> + static OptionDesc ace_options[] = {
>
>