Re: [New] devel/fmt

On Sat, Jan 02 2021, Rafael Sadowski <rafael@sizeofvoid.org> wrote:
> On Sat Jan 02, 2021 at 03:44:22PM +0100, Jeremie Courreges-Anglas wrote:
>> On Tue, Dec 15 2020, Ashton Fagg <ashton@fagg.id.au> wrote:
>> > Ping. Updated version attached.
>>
>> BTW upstream provides proper releases upstream, see the zip files at
>> https://github.com/fmtlib/fmt/releases
>> Usually I would suggest using said tarballs, but here it doesn't seem to
>> bring a significant improvement (generating the documentation would
>> still require extra bdeps). Such possible improvements can be done
>> in-tree.
>>
>> We need another ok to import this. Same tarball attached for convenience.
>
> OK rsadowski@

Thanks Rafael & Marc. :)

While we're here: using codesearch.debian.net I looked for possible
ports that might pick this up, and I only found mkvtoolnix (newer
osm2pgsql could, but our version doesn't use fmt).

So Rafael, regarding mkvtoolnix, either we use the bundled fmt with

CONFIGURE_ENV= ac_cv_fmt=no

or we reuse the system library as in the diff below.

While here, I noticed that cmark is only used when building qt.

ok?


Index: Makefile
===================================================================
RCS file: /cvs/ports/multimedia/mkvtoolnix/Makefile,v
retrieving revision 1.96
diff -u -p -r1.96 Makefile
--- Makefile 2 Dec 2020 06:44:11 -0000 1.96
+++ Makefile 2 Jan 2021 16:14:15 -0000
@@ -3,6 +3,7 @@
COMMENT= create, alter and inspect Matroska files

DISTNAME= mkvtoolnix-51.0.0
+REVISION= 0

CATEGORIES= multimedia x11

@@ -14,7 +15,7 @@ MAINTAINER = Rafael Sadowski <rsadowski@
PERMIT_PACKAGE= Yes

WANTLIB += ${COMPILER_LIBCXX} FLAC boost_filesystem-mt
-WANTLIB += boost_system-mt c cmark dvdread ebml iconv intl m magic
+WANTLIB += boost_system-mt c dvdread ebml fmt iconv intl m magic
WANTLIB += matroska ogg pcre2-8 pugixml vorbis z

MASTER_SITES= https://www.bunkus.org/videotools/mkvtoolnix/sources/
@@ -38,12 +39,12 @@ LIB_DEPENDS= audio/flac \
audio/libogg \
audio/libvorbis \
devel/boost \
+ devel/fmt \
devel/gettext,-runtime \
devel/libdvdread \
devel/libmagic \
devel/pcre2 \
multimedia/libmatroska>=1.6.2 \
- textproc/cmark \
textproc/libebml>=1.4.0 \
textproc/pugixml

@@ -71,8 +72,9 @@ CONFIGURE_ARGS+= --disable-gui
.else
MODULES+= x11/qt5
WANTLIB += Qt5Concurrent Qt5Core Qt5DBus Qt5Gui Qt5Multimedia Qt5Network
-WANTLIB += Qt5Widgets
-LIB_DEPENDS += x11/qt5/qtmultimedia
+WANTLIB += Qt5Widgets cmark
+LIB_DEPENDS += x11/qt5/qtmultimedia \
+ textproc/cmark
RUN_DEPENDS+= devel/desktop-file-utils \
misc/shared-mime-info \
x11/gtk+3,-guic


--
jca | PGP : 0x1524E7EE / 5135 92C1 AD36 5293 2BDF DDCC 0DFA 74AE 1524 E7EE