Re: NEW: x11/mlvwm

On Wed, Jan 27, 2021 at 5:00 PM Stuart Henderson <stu@spacehopper.org> wrote:
> On 2021/01/27 16:32, Morgan Aldridge wrote:
> > On Wed, Jan 27, 2021 at 1:47 PM Solene Rapenne <solene@perso.pw> wrote:
> > >
> > > The port looks fine for me at the exception of the compilation using
> > > -g, this has to be patched.
> > >
> > > ===> Building for mlvwm-0.9.2
> > > making all in ./mlvwm...
> > > cc -g -Wall -Wshadow -I/usr/local/include -I/usr/X11R6/include [...]
> >
> > Oops! Patch added to remove `-g`.
> >
> > > Using your configuration generator I've been able to try it, it
> > > worked fine so far. I am afraid it'd be really hard to configure
> > > for people wanting to try it if they don't have the link to your
> > > configuration.
> >
> > I'm glad it's working and I agree on the configuration point. I have
> > added a pkg-readme that directs users to the
> > https://github.com/morgant/mlvwmrc project, but maybe it's too
> > verbose?
> >
> > > As for the licence name, I'd prefer someone with more experience
> > > in this. I'm not sure Freeware is ok.
> >
> > Yes, I'm concerned about this as well and welcome all input.
> >
> > Updated tarball attached. Many thanks for testing this, Solene!
> >
> > Morgan
>
> : COMMENT = Macintosh-like virtual window manager
> : DISTNAME = mlvwm-0.9.2
> : CATEGORIES = x11
> :
> : HOMEPAGE = https://github.com/morgant/mlvwm/
> : MAINTAINER = Morgan Aldridge <morgant@makkintosshu.com>
> :
> : # Freeware
> : PERMIT_PACKAGE = Yes
> :
> : WANTLIB += X11 Xau Xdmcp Xext Xpm c
> : MASTER_SITES = https://github.com/morgant/mlvwm/releases/download/0.9.2/
>
> please use a variable to avoid changing release ver in two places.

Will do.

> :
> : BUILD_DEPENDS = devel/imake
> : CONFIGURE_STYLE = imake
>
> oh my...an imake-based port in 2021! setting CONFIGURE_STYLE automatically
> adds this to BUILD_DEPENDS so there's no need to list that here too

I plan to migrate off of imake in a future release.

> Here's a diff on top for the above, it also adjusts the license marker,
> and honours CC/CFLAGS. OK with me with this added.
>
> diff 2329fb643b7819bb6ef0fa0d7156041681d597b0 /usr/ports/mystuff
> blob - f5b9e61031d17413cc3764916707827cb9b474e0
> file + x11/mlvwm/Makefile
> --- x11/mlvwm/Makefile
> +++ x11/mlvwm/Makefile
> @@ -1,20 +1,23 @@
> # $OpenBSD: Makefile.template,v 1.88 2020/05/15 01:32:48 abieber Exp $
>
> COMMENT = Macintosh-like virtual window manager
> -DISTNAME = mlvwm-0.9.2
> +
> +V = 0.9.2
> +DISTNAME = mlvwm-$V
> CATEGORIES = x11
>
> HOMEPAGE = https://github.com/morgant/mlvwm/
> MAINTAINER = Morgan Aldridge <morgant@makkintosshu.com>
>
> -# Freeware
> +# part MIT part Freeware, see README.md
> PERMIT_PACKAGE = Yes
>
> WANTLIB += X11 Xau Xdmcp Xext Xpm c
> -MASTER_SITES = https://github.com/morgant/mlvwm/releases/download/0.9.2/
>
> -BUILD_DEPENDS = devel/imake
> +MASTER_SITES = https://github.com/morgant/mlvwm/releases/download/$V/
> +
> CONFIGURE_STYLE = imake
> +MAKE_FLAGS = CC="${CC}" COPTS="${CFLAGS}"
> NO_TEST = Yes
>
> .include <bsd.port.mk>
>

Thanks for the review and the patch, Stuart! Updated tarball attached
with patch applied for convenience.

Morgan