Re: security/libsrtp -fno-common

On Sun, 31 Jan 2021 12:03:39 +0000
Stuart Henderson <stu@spacehopper.org> wrote:

> On 2021/01/31 12:58, Charlene Wendling wrote:
> > On Sun, 31 Jan 2021 16:38:02 +1100
> > Jonathan Gray <jsg@jsg.id.au> wrote:
> >
> > > https://github.com/cisco/libsrtp/commit/716a73862b387a2107f37398c0fb7d9a754c0ccd.patch
> > >
> > > /tmp/libsrtp2.so.1.0 --> /usr/local/lib/libsrtp2.so.2.0
> > > Dynamic export changes:
> > > removed:
> > > bit_string
> > >
>
> Deps still work, OK with me.
>
> > Tested on amd64 and macppc (vanilla clang there). It needs itself
> > to be installed for tests to run, i've tweaked your diff to do so.
>
> Can you paste a log please, I don't see that?


Huh, weird. I have attached the log.

> $ ls /var/db/pkg/*srtp*
> ls: /var/db/pkg/*srtp*: No such file or directory
>
> ...
>
> ===> Regression tests for libsrtp-2.3.0p1
> Build done. Please run 'gmake runtest' to run self tests.
> running libsrtp2 test applications...
> crypto/test/cipher_driver -v >/dev/null
> crypto/test/kernel_driver -v >/dev/null
> test/test_srtp >/dev/null
> test/rdbx_driver -v >/dev/null
> test/srtp_driver -v >/dev/null
> test/roc_driver -v >/dev/null
> test/replay_driver -v >/dev/null
> test/dtls_srtp_driver >/dev/null
> cd
> test; /usr/obj/ports/libsrtp-2.3.0/libsrtp-2.3.0/test/rtpw_test.sh
> -w /usr/obj/ports/libsrtp-2.3.0/libsrtp-2.3.0/test/words.txt
> >/dev/null libsrtp2 test applications passed. gmake -C crypto runtest
> >gmake[1]: Entering directory
> >'/usr/obj/ports/libsrtp-2.3.0/libsrtp-2.3.0/crypto'
> test/env # print out information on the build environment
> CPU set to little-endian (WORDS_BIGENDIAN == 0)
> CPU set to CISC (CPU_CISC == 1)
> using native 64-bit type (NO_64_BIT_MATH == 0)
> running crypto test applications...
> test `test/aes_calc 000102030405060708090a0b0c0d0e0f
> 00112233445566778899aabbccddeeff` = 69c4e0d86a7b0430d8cdb78070b4c55a
> test `test/aes_calc
> 000102030405060708090a0b0c0d0e0f101112131415161718191a1b1c1d1e1f
> 00112233445566778899aabbccddeeff` = 8ea2b7ca516745bfeafc49904b496089
> test/cipher_driver -v >/dev/null test/datatypes_driver -v >/dev/null
> test/stat_driver >/dev/null test/sha1_driver -v >/dev/null
> test/kernel_driver -v >/dev/null crypto test applications passed.
> gmake[1]: Leaving directory
> '/usr/obj/ports/libsrtp-2.3.0/libsrtp-2.3.0/crypto'
>