Re: [UPDATE] graphics/openimageio

On Sun, 03 Jan 2021 19:46:29 +0100, Jeremie Courreges-Anglas wrote:
> On Sun, Jan 03 2021, Dimitri Karamazov <deserter666@danwin1210.me> wrote:
> > Update graphics/openimageio to 2.2.10.0
> >
> > Build & run tested blender with it.
> > 14 out of 54 tests fail.
> > Atleast 3 of them fail because of some
> > optional dependencies not being turned on.
> > Like OpenVDB,libheif and ptex.
>
> > Removed the USE_DICOM option since it
> > is optional now.
>
> It may be optional, but it is still used if available:
>
> (after a make configure)
> --8<--
> russell /usr/ports/graphics/openimageio$ doas pkg_delete dcmtk
> dcmtk-3.6.3p0: ok
> Read shared items: ok
> russell /usr/ports/graphics/openimageio$ make all MAKE_JOBS=2 2>&1 | tee log2
> ===> Building for openimageio-2.2.10.0
> ninja: error: '/usr/local/lib/libdcmimage.so.0.0', needed by
> 'lib/libOpenImageIO.so.8.0', missing and no known rule to make it
> -->8--
>
> Optional deps for which we have ports should be explicitely enabled or
> disabled, to avoid problems during bulk builds. See the commit log:
>
> revision 1.44
> date: 2020/10/26 18:37:59; author: jca; state: Exp; lines: +3 -2; commitid: tLqO00IGaKrpp8i9;
> Don't pick up dcmtk if available
>
> Force-disable the dep for now, can be reconsidered later if DICOM
> support is deemed valuable.

Yes, this should be left in.

> While here, openimageio is only used by blender, for which you're the
> new maintainer. Should you also take over maintainership of this port?

Yes, I think you should. :)

> --
> jca | PGP : 0x1524E7EE / 5135 92C1 AD36 5293 2BDF DDCC 0DFA 74AE 1524 E7EE